Consistently sort and group all TS imports #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mfisher87
force-pushed
the
import-sorting-and-grouping
branch
from
acc5b61 to
c69f97b
Compare
|
Integration tests report: appsharing.space |
4 tasks
mfisher87
force-pushed
the
import-sorting-and-grouping
branch
from
4b125d4 to
d9440ad
Compare
martinRenou
approved these changes
Jun 4, 2025
|
I'm currently rebasing the source code changes, one moment :) |
|
@martinRenou you should see source code changes now |
elifsu-simula
pushed a commit
to elifsu-simula/jupytergis
that referenced
this pull request
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Depends on #728 , merge that first.
Sort and group imports in our TS following the same pattern as our Python code using eslint plugin.
First builtin, then third-party, then local imports.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--730.org.readthedocs.build/en/730/
💡 JupyterLite preview: https://jupytergis--730.org.readthedocs.build/en/730/lite