Make add layer menus more consistent

[mfisher87]

Description

Resolves #655

The right-click menu in the layer panel's "Add Layer" submenu looks different than the "Add Layer" menu in the toolbar.
The toolbar also contains two dedicated "Add Layer" buttons that I've moved into the "Add Layer" menu.

I extracted the raster and vector layer submenus into functions so we can create the exact same sub-menus in both the layer panel right-click and toolbar contexts.

Checklist

• PR has a descriptive title and content.
• PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
• PR has one of the labels: documentation, bug, enhancement, feature, maintenance
• Checks are passing.
  Failing lint checks can be resolved with:
  • pre-commit run --all-files
  • jlpm run lint

---

📚 Documentation preview: https://jupytergis--681.org.readthedocs.build/en/681/
💡 JupyterLite preview: https://jupytergis--681.org.readthedocs.build/en/681/lite

[github-actions]

👈 Launch a Binder on branch mfisher87/jupytergis/more-consistent-add-layer-experience

[github-actions]

Integration tests report: appsharing.space

[mfisher87]

please update snapshots

[mfisher87]

I'm a bit confused.

One of the update snapshots jobs failed, but I don't understand why it failed the way it did.

The Lite integration tests are failing on a snapshot that doesn't exist (Render-notebook.png). The snapshot that was updated was rendered with incomplete tiling. What am I missing here?

[mfisher87]

please update snapshots

[mfisher87]

The GIBS layer in the france hiking example seems to be pretty unreliable, and I don't think it fits very well with that example either. Let's remove it or replace it with a different layer?

[martinRenou]

Thanks a lot!

I want to suggest to remove the commands that we were using for creating layers from the left side panel. Those commands were used for creating layers without creating an associated source, since now the source panel was removed we can probably simplify this too and remove those commands.

[mfisher87]

@martinRenou 3046272 ffcbf0c

Any thoughts on the integration tests?

Done!

[arjxn-py]

Retriggering the CI as the failure looks to be related to tile loading on map

[martinRenou]

Yeah this test has been unreliable since some days now due to tile loading issue. We can discard it for now, but ideally we would wait more before taking the screenshot, or use another test.

[martinRenou]

Thanks!! That's looks much better, and the code cleanup is much welcome

[mfisher87]

@martinRenou if you have thoughts about more areas that could use urgent cleanup, let's open issues. I love refactoring and deleting code ;)

[martinRenou]

Deleting code is the best 😆 that's the best way to remove bugs