Skip to content

Cleanup examples #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

Cleanup examples #162

merged 1 commit into from
Sep 24, 2024

Conversation

martinRenou
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytergis/cleanup_examples

@martinRenou martinRenou merged commit 27f26c2 into geojupyter:main Sep 24, 2024
5 checks passed
@martinRenou martinRenou deleted the cleanup_examples branch September 24, 2024 16:20
@brichet
Copy link
Collaborator

brichet commented Oct 1, 2024

@martinRenou, it seems that some ui tests were using the example/test.jGIS file:

jupytergis/ui-tests/tests/layer-browser.spec.ts

Line 109 in 6729974

await page.filebrowser.open('examples/test.jGIS');

@brichet brichet mentioned this pull request Oct 1, 2024
Merged
@martinRenou
Copy link
Member Author

Right! My bad for merging this too fast 😁

We should not depend on the examples directory for tests anymore though. Let's just rely on ui-tests/tests/gis-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @brichet