PR: Cache correlation coefficients #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is absolutely no need to compute the coefficient every time. We only need to do it once.
|
Hello @jnsebgosselin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
jnsebgosselin
added
component: gapfill data
type: enhancement
jnsebgosselin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the correlation coefficient are calculated for ALL stations every time the target station is changed.
This PR improve this by caching the correlation coefficients in memory and on the disk, so that they are calculated only once. The correlation coefficient are recalculated only when a change is made to the dataset.