Skip to content

PR: Don't block GUI when loading data and calculating correlation coefficient #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 6, 2020
Merged

PR: Don't block GUI when loading data and calculating correlation coefficient #13

merged 25 commits into from
Nov 6, 2020

Conversation

jnsebgosselin
Copy link
Member

@jnsebgosselin jnsebgosselin commented Nov 5, 2020 •
edited
Loading

This PR implement changes that allows loading data and calculating correlation coefficient in another thread so that the GUI doesn't become unresponsive.

This was required because the application became unusable at some point as more neighboring stations were added to the calculation.

@jnsebgosselin
Add a taskmanagers module
6e33a3e
@jnsebgosselin
Add a DataGapfillManager class
edc78eb
@jnsebgosselin
Rename DataGapfiller -> DataGapfillWorker and inherit from WorkerBase
dddb5a8
@jnsebgosselin
DataGapfillWorker: rework gapfill_data to take arguments
7dad736
@jnsebgosselin
WeatherDataGapfiller: use the new DataGapfillManager
9e67c7a
@jnsebgosselin
DataGapfillWorker: add substeps increment in sig_gapfill_progress
518d4cc
@jnsebgosselin
WeatherDataGapfiller: reorganize code
ff29533
@jnsebgosselin
WeatherDataGapfiller: move get_gapfill_parameters
e36ad2e
@jnsebgosselin
DataGapfillManager: add logic for status messages
6fb592c
@jnsebgosselin
DataGapfillManager: add logic to set target station
bedc38b
@jnsebgosselin
DataGapfillWorker: fix missing data warning in gapfill_data
d2ec8f8
@jnsebgosselin
WeatherDataGapfiller: don't freeze ui when calculating corr coeff
6d615a7
@jnsebgosselin
DataGapfillManager: add get_station_names and get_station_ids methods
f15b948
@jnsebgosselin
DataGapfillManager: add load_data
4674c4d
@jnsebgosselin
WeatherDataGapfiller: dont block ui when loading data
6c53d79
@jnsebgosselin
Add status text in a status bar
81441c6
@jnsebgosselin
Rename sig_gapfill_progress -> sig_task_progress
6f27d3c
@jnsebgosselin
Add load data progress
d866b15
@pep8speaks
Copy link

pep8speaks commented Nov 5, 2020 •
edited
Loading

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 314:21: E123 closing bracket does not match indentation of opening bracket's line

Line 520:13: E123 closing bracket does not match indentation of opening bracket's line

Comment last updated at 2020-11-06 15:27:34 UTC

@jnsebgosselin jnsebgosselin self-assigned this Nov 5, 2020
@jnsebgosselin jnsebgosselin modified the milestones: 0.1.2, 0.2 Nov 5, 2020
@jnsebgosselin jnsebgosselin merged commit 03fc62a into master Nov 6, 2020
@jnsebgosselin jnsebgosselin deleted the load_data_in_a_thread branch November 6, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: gapfill data
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jnsebgosselin @pep8speaks