-
Notifications
You must be signed in to change notification settings - Fork 21
Update deps #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #666
Conversation
Overview
Packages and Vulnerabilities (63 package changes and 6 vulnerability changes)
Changes for packages of type
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the Go version and related dependencies to v1.24 while replacing usage of context.Background() with the test-provided context (t.Context()) in tests. In addition, it adds explicit calls to discard the HTTP request body in several API endpoints.
Reviewed Changes
File | Description |
---|---|
api/v1/api.pb.gw.go | Added io.Copy calls to discard request bodies in API endpoints. |
api/http_server_test.go | Replaced context.Background() with t.Context() in HTTP server tests. |
.github/workflows/release.yaml | Updated Go version from 1.23 to 1.24. |
.github/workflows/test.yaml | Updated Go version from 1.23 to 1.24. |
metrics/merger_test.go & others | Updated tests to use t.Context() consistently. |
config/, act/, logging/, api/ | Various tests updated to use t.Context() for context propagation. |
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
@sinadarbouy Do you have any idea why the tests are failing. I see a cryptic message possibly from Raft, but I cannot find the source of it. It's about the transaction rollbacks. |
@mostafa Hmm, not sure about transaction rollbacks—probably okay because the related test cases passed. However, these two test cases failed: FAIL: |
Ticket(s)
N/A
Description
Related PRs
N/A
Development Checklist
make gen-docs
command.Legal Checklist