Plugin system #40
Merged
Plugin system #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in system Rename Prio to Priority Change HookDef to reflect the signature of the gRPC functions Use structpb.Struct to encapsulate messages as/like JSON Move Verify method to the utils.go file Change Run function signature to include a context.Context and grpc.CallOptions Return error from the Run function Add SHA256 checksum verification function for plugin files
…used by plugins Update protobuf file to reflect the changes in the plugin system and hooks Generate the latest version of protobuf stubs for Go and go-gRPC
…ation Rename configFile to globalConfigFile Add pluginConfigFile and pluginConfig koanf object Add an instance of the plugin registry Add a default logger Add loading of all plugins before anything happens Use the OnConfigLoaded hook to call plugins and update the config in-memory Update hooks.Run function to use the parameter signatures needed Add an example gatewayd_plugin.yaml file for testing
Stop swallowing conversion errors
This was
linked to
issues
Dec 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the plugin system. The plugin system is based on the Hashicorp's go-plugin and tries to run plugins from a locally-accessible directory to GatewayD binary.
It has various parts:
I also developed a minimal test plugin, gateway-plugin-test, to show how one can write a plugin for GatewayD. I'll try to optimize the plugin system as the project moves forward.