Skip to content

Remove ReturnFrom and with it, the return!-enabled tailcalls #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Remove ReturnFrom and with it, the return!-enabled tailcalls #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/FSharpy.TaskSeq.Test/TaskSeq.Tests.CE.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,21 +110,6 @@ let ``CE taskSeq with nested deeply yield! perf test 8521 nested tasks`` () = ta
data |> should equal (List.ofSeq expected) // cannot compare seq this way, so, List.ofSeq it is
}

[<Fact>]
let ``CE taskSeq with several return!`` () = task {
// TODO: should we even support this? Traditional 'seq' doesn't.
let tskSeq = taskSeq {
return! Gen.sideEffectTaskSeq 10
return! Gen.sideEffectTaskSeq 5
}

let! data = tskSeq |> TaskSeq.toListAsync

// FIXME!!! This behavior is *probably* not correct
data |> should equal [ 1..10 ]
}


[<Fact>]
let ``CE taskSeq with mixing yield! and yield`` () = task {
let tskSeq = taskSeq {
Expand Down
Loading