Adjust Data code #52
Closed
Adjust Data code #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is, partially fixed Issue has to do with the MemberwiseClone() for shadowing the enumerator is not enough to reset the necessary states. Furthermore, after this is sorta fixed, the ValueTask that is used to keep the MoveNext boolean gets accessed twice asynchronously, which is not allowed. It also seems that using 'use' on the taskSeq.GetAsyncEnumerator fails by double disposing. This can probably be considered "by design" but should carefully be considered.
…getting InvalidState exceptions
…ined, instead return default value for type
…ence is completed
… of the async stream
…h solves calling MoveNextAsync() multiple times after completion and removes the InvalidStateException
…cessed in lock step, or individually to completion
…w Enumerator, after a full loop through all items
…tors when tasks are yielded, instead of concrete
|
Not sure why the CI doesn't kick off. Is this still needed, btw? I'll see if I can resolve the conflicts. |
|
yeah, after merging and fixing the conflicts, there are no changes anymore, so I'll close this out. |
abelbraaksma
added
bug fix
investigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.