Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
498 commits
Select commit Hold shift + click to select a range
8c5a58c
Merge pull request #7012 from KevinRansom/mergemastertofsharp47
KevinRansom Jun 18, 2019
ce98492
properly fail the build on unix failures (#7015)
brettfo Jun 18, 2019
cb880d5
Fixed line directive ranges when not applying a line directive (#7011)
TIHan Jun 18, 2019
b900968
Remove IVTs to legacy language service (#7001)
cartermp Jun 19, 2019
66a209a
[master] Update dependencies from dotnet/arcade (#7013)
dotnet-maestro[bot] Jun 19, 2019
51684d4
Add get/set to item description tooltip (#7016)
cartermp Jun 20, 2019
fa5ef91
[master] Update dependencies from dotnet/arcade (#7023)
dotnet-maestro[bot] Jun 21, 2019
50e3d35
Merge pull request #7038 from dotnet/merges/release/dev16.2-to-releas…
Jun 21, 2019
1a1ae4b
Merge pull request #7029 from dotnet/merges/master-to-release/dev16.3
Jun 21, 2019
5289eb0
Merge pull request #7028 from dotnet/merges/release/dev16.2-to-releas…
Jun 21, 2019
4d15e56
update package versions for 16.1 (#6994)
brettfo Jun 22, 2019
7ee0b8c
Merge pull request #7042 from dotnet/merges/master-to-release/dev16.3
brettfo Jun 22, 2019
6633abe
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jun 22, 2019
4f6aecc
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jun 23, 2019
5e68e76
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jun 24, 2019
0de649d
Ignore ionide (#7059)
forki Jun 25, 2019
e2693ce
Merge pull request #7053 from dotnet/darc-master-ee187335-5c39-4328-9…
KevinRansom Jun 25, 2019
108428b
Update several links (#7055)
milbrandt Jun 25, 2019
6d69922
Remove dead code (#7068)
forki Jun 27, 2019
86f8b17
Avoid allocating in IsOperatorName (#7061)
forki Jun 27, 2019
c3b6dff
Fix build GenerateDocs (#7054)
milbrandt Jun 27, 2019
6af64a7
List.transpose should throw error when given jagged array (#6908) (#6…
PatrickMcDonald Jun 27, 2019
010bd00
Added -noVisualStudio flag for build.cmd. (#7071)
TIHan Jun 28, 2019
5a8f454
Use a MaxBuffer for Suggestions (#7060)
forki Jun 28, 2019
459162b
Merge pull request #7084 from dotnet/merges/master-to-release/dev16.3
Jul 1, 2019
77121fd
Merge branch 'release/fsharp47' into feature/nameof
dsyme Jul 1, 2019
5306722
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 1, 2019
6bdbe9d
Fix fsharp47 (#7091)
KevinRansom Jul 2, 2019
787d4c5
Merge pull request #7092 from dotnet/merges/master-to-release/dev16.3
Jul 2, 2019
4d724f2
Reorder and clarify devguide (#7082)
cartermp Jul 2, 2019
d7cee80
Merge pull request #7094 from dotnet/merges/master-to-release/dev16.3
Jul 2, 2019
f878da6
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 2, 2019
d51ae07
Merge pull request #7100 from dotnet/merges/master-to-release/dev16.3
Jul 3, 2019
8b66074
Improve diagnostics and disable flakey test (#7113)
KevinRansom Jul 3, 2019
ab2e8fa
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 3, 2019
7891cbd
Merge branch 'release/fsharp47' into merges/release/dev16.3-to-releas…
KevinRansom Jul 3, 2019
be82736
Allow to set PreferredUILang from tests (#7102)
forki Jul 3, 2019
92e4a52
Merge pull request #6809 from dotnet/feature/nameof
KevinRansom Jul 3, 2019
1b6cf9f
Apparently the unit test dll's don't use fsharptest.directory.props (…
KevinRansom Jul 3, 2019
383d316
versioning tests
KevinRansom Jul 3, 2019
b26941b
Merge pull request #7105 from dotnet/merges/release/dev16.3-to-releas…
Jul 4, 2019
98e4893
Add langversion support for nameof
KevinRansom Jul 4, 2019
267a971
fsi, correct error messages
KevinRansom Jul 4, 2019
20690ca
Use latest Paket (#7124)
forki Jul 4, 2019
274ffb1
Use more specific assertions in CompilerAssert (#7122)
forki Jul 4, 2019
681d9d5
Use --langversion:preview for conformance tests
KevinRansom Jul 4, 2019
2d8eb0e
fix matching mistake
dsyme Jul 4, 2019
26342bc
Update NameResolution.fs
dsyme Jul 4, 2019
277b0fd
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jul 4, 2019
a7a66e3
Merge pull request #7125 from KevinRansom/langversion-nameof
KevinRansom Jul 4, 2019
d1b64e6
Merge pull request #7126 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 4, 2019
cfb414f
[RFC FS-1069] Implicit yields (allow dropping yield in list, array, s…
dsyme Jul 4, 2019
8c33139
Add FSharpChecker.ParseFileNoCache (#7108)
auduchinok Jul 4, 2019
7d4590d
Merge pull request #7129 from dotnet/darc-master-52eb964e-8052-4120-9…
KevinRansom Jul 4, 2019
1524916
Merge branch 'release/fsharp47' into merges/release/dev16.3-to-releas…
KevinRansom Jul 5, 2019
dc19afe
Merge pull request #7137 from dotnet/merges/release/dev16.3-to-releas…
Jul 5, 2019
a63be48
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jul 5, 2019
f764e6b
support struct tuple in leaf expression converter (#7144)
kevmal Jul 5, 2019
2c75ff3
Merge pull request #7131 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 5, 2019
8bfca24
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jul 6, 2019
2c95ddd
Merge pull request #7148 from dotnet/merges/release/dev16.3-to-releas…
KevinRansom Jul 6, 2019
28ef31d
Merge pull request #7145 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 6, 2019
f2e9ed1
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jul 7, 2019
77b5521
Merge pull request #7143 from dotnet/darc-master-8f1390e2-a78f-411e-b…
KevinRansom Jul 7, 2019
5abc7d6
Merge pull request #7159 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 9, 2019
5a91e91
Merge pull request #7154 from dotnet/merges/release/dev16.3-to-releas…
Jul 9, 2019
274c9a0
[RFC FS-1068] open static classes (#6807)
dsyme Jul 9, 2019
0a90022
[master] Update dependencies from dotnet/arcade (#7162)
dotnet-maestro[bot] Jul 9, 2019
e057f09
Always recover when trying to parse inline IL (#7167)
TIHan Jul 10, 2019
14d9768
Merge pull request #7168 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 10, 2019
91d783f
Always recover when trying to parse inline IL (#7167) (#7176)
TIHan Jul 10, 2019
017d5cf
Merge pull request #7173 from dotnet/merges/release/dev16.3-to-releas…
KevinRansom Jul 10, 2019
be1cdd7
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jul 10, 2019
c807da6
Merge pull request #7178 from dotnet/merges/master-to-release/dev16.3
Jul 10, 2019
bc4edc6
Merge branch 'release/fsharp47' into merges/release/dev16.3-to-releas…
TIHan Jul 10, 2019
b3f4e98
Stack overflow fixes (#7151)
TIHan Jul 10, 2019
dbee477
Merge pull request #7186 from dotnet/darc-master-87da76fa-f9cd-4fd7-b…
KevinRansom Jul 10, 2019
658caa2
Merge pull request #7183 from dotnet/merges/release/dev16.3-to-releas…
brettfo Jul 10, 2019
4f99eeb
Merge branch 'release/dev16.3' into merges/master-to-release/dev16.3
TIHan Jul 10, 2019
7d5f12d
Merge pull request #7187 from dotnet/merges/master-to-release/dev16.3
Jul 10, 2019
ef0949c
Copy sources from Versions.props to NuGet.config (#7191)
Jul 11, 2019
1bc2896
Implement Langversion switch for implicit yields (#7166)
KevinRansom Jul 11, 2019
0c9ccae
Only check distinct errors (#7140)
forki Jul 11, 2019
928d050
Merge branch 'release/fsharp47' into merges/release/dev16.3-to-releas…
KevinRansom Jul 11, 2019
b6f0be9
Merge pull request #7192 from dotnet/merges/release/dev16.3-to-releas…
Jul 11, 2019
598db3e
Use 1-based column numbers in tests (#7141)
forki Jul 11, 2019
fe0426a
Merge pull request #7197 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 11, 2019
bf1055c
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 11, 2019
742449a
Implement langversion switch for openstaticclasses (#7195)
KevinRansom Jul 12, 2019
13596c4
Merge pull request #7201 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 12, 2019
da432e1
Better record and value formatting in tools (#7021)
cartermp Jul 12, 2019
f5f7f0f
Enable 4.7 by default (#7204)
KevinRansom Jul 12, 2019
660a545
fix portable PDBs for anon records (#7099)
dsyme Jul 12, 2019
9dc9d0e
fix portable PDBs for anon records (#7099)
dsyme Jul 12, 2019
60c915a
Moving ElseBranchHasWrongTypeTests over to NUnit (#7104)
forki Jul 12, 2019
869c2bb
Port tests for missing else branch to NUnit (#7209)
forki Jul 12, 2019
c80a0cb
Merge pull request #7208 from KevinRansom/cherrypickfix
KevinRansom Jul 12, 2019
2fabdaa
Merge pull request #7213 from dotnet/merges/master-to-release/dev16.3
brettfo Jul 12, 2019
59bfc83
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 12, 2019
8ab272a
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jul 13, 2019
1ad5657
Merge pull request #7222 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 13, 2019
b7d5efd
Merge branch 'release/dev16.3' into merges/release/fsharp47-to-releas…
KevinRansom Jul 13, 2019
7780cab
Fix Supplementary Character / Surrogate Pair info (no code changes) (…
srutzky Jul 13, 2019
30cce45
Merge pull request #7228 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 14, 2019
0abf39c
Merge pull request #7223 from dotnet/merges/release/fsharp47-to-relea…
KevinRansom Jul 14, 2019
f9a8e2a
Update IlxGen.fs (#7227)
TIHan Jul 14, 2019
c79a8ab
Merge pull request #7225 from dotnet/darc-master-1d1b7b40-d7f9-4b9d-9…
KevinRansom Jul 14, 2019
ec8a424
Check for exit code in compiler tests (#7211)
forki Jul 14, 2019
c4dba1f
Moving AccessOfTypeAbbreviationTests over to NUnit (#7226)
sergey-tihon Jul 14, 2019
f720c73
Merge pull request #7230 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 14, 2019
75cef56
Moving ConstructorTests over to NUnit (#7236)
sergey-tihon Jul 15, 2019
c7cd220
[master] Update dependencies from dotnet/arcade (#7233)
dotnet-maestro[bot] Jul 15, 2019
0f24b3e
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 16, 2019
863ec25
Moving UpcastDowncastTests over to NUnit (#7229)
sergey-tihon Jul 16, 2019
c8bac72
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 17, 2019
6980587
Move ErrorMessages/NameResolution Tests to NUnit (#7237)
kMutagene Jul 17, 2019
4cf7b5b
Moving WarnExpressionTests over to NUnit (#7232)
sergey-tihon Jul 17, 2019
2f270f2
Merge pull request #7241 from dotnet/merges/master-to-release/dev16.3
KevinRansom Jul 17, 2019
650805b
move some error and warning tests to NUnit (#7244)
smcl Jul 17, 2019
375fd7c
Update dependencies from https://github.com/dotnet/arcade build 20190…
Jul 18, 2019
8d74566
Merge pull request #7253 from dotnet/darc-master-648345c2-b59c-4cd2-9…
KevinRansom Jul 19, 2019
c423de9
Move UnitGenericAbstractType To Nunit (#7257)
falfaddaghi Jul 19, 2019
4151eb2
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 19, 2019
bdb2b79
Moving TypeMismatchTests over to NUnit (#7250)
sergey-tihon Jul 19, 2019
b0e5926
publish pdbs in FSharp.Core.nupkg (#7255)
brettfo Jul 19, 2019
3e7b66d
Enable hash algorithm selection (#7252)
KevinRansom Jul 20, 2019
c70ead8
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 20, 2019
ff7b8ff
Improve netcore reference selection (#7263)
KevinRansom Jul 22, 2019
d53a38c
Moving Libraries Control tests to NUnit (#7234)
thinkbeforecoding Jul 22, 2019
5efa8a7
Member constraints and PrimitiveConstraints (#7210)
forki Jul 22, 2019
a7c68c3
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 23, 2019
a67156b
Merge branch 'master' into merges/release/dev16.2-to-master
brettfo Jul 24, 2019
0bd851b
Merge pull request #7272 from dotnet/merges/release/dev16.2-to-master
Jul 25, 2019
37970b4
fixes issue #6832 (#7259)
KevinRansom Jul 25, 2019
d979174
Color nameof as intrinsic (#7273)
cartermp Jul 25, 2019
8e843ae
[master] Update dependencies from dotnet/arcade (#7269)
dotnet-maestro[bot] Jul 26, 2019
b3811d2
Merge pull request #7279 from dotnet/merges/release/fsharp47-to-relea…
Jul 26, 2019
ce483c0
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 26, 2019
969a9c4
Fix test assert (#7283)
KevinRansom Jul 26, 2019
2304ea4
merge
KevinRansom Jul 26, 2019
c03755f
disablewarningtests
KevinRansom Jul 27, 2019
d488458
Merge pull request #7266 from dotnet/merges/master-to-release/dev16.3
Jul 27, 2019
cc60ed6
code cleanup prior to optional interop improvements (#7276)
dsyme Jul 27, 2019
e72ded1
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 27, 2019
bdb229c
Moving ClassesTests over to NUnit (#7264)
sergey-tihon Jul 27, 2019
8370ef6
Move Basic Constants to NUnit (#7262)
falfaddaghi Jul 27, 2019
3ce8eb1
Moved Don't Suggest Tests over to NUnit (#7288)
sergey-tihon Jul 29, 2019
868b76a
[master] Update dependencies from dotnet/arcade (#7287)
dotnet-maestro[bot] Jul 29, 2019
9c1a0d1
Fix langversion with multiple projects (#7293)
KevinRansom Jul 30, 2019
8edf449
Merge remote-tracking branch 'upstream/master' into merges/master-to-…
brettfo Jul 30, 2019
54f13f0
Merge pull request #7292 from dotnet/merges/master-to-release/dev16.3
Jul 30, 2019
897afd3
Merge pull request #7301 from KevinRansom/release/fsharp47
brettfo Jul 30, 2019
8e8a754
Merge pull request #7302 from dotnet/merges/release/fsharp47-to-relea…
Jul 31, 2019
2e17274
exclude FSharp.Compiler.LanguageServer from source build (#7304)
brettfo Jul 31, 2019
e1c5ca2
[master] Update dependencies from dotnet/arcade (#7295)
dotnet-maestro[bot] Jul 31, 2019
bacfc07
Merge pull request #7305 from dotnet/merges/master-to-release/dev16.3
Aug 1, 2019
a213738
Activate hanging test file (#7298)
forki Aug 1, 2019
6e46c5a
Merge pull request #7313 from dotnet/merges/master-to-release/dev16.3
Aug 1, 2019
b62bb71
Added some utilities that will be helpful for testing (#7321)
TIHan Aug 2, 2019
bde3682
Fix suggestions (#7311)
KevinRansom Aug 2, 2019
cf19605
Merge pull request #7323 from dotnet/merges/master-to-release/dev16.3
Aug 2, 2019
90f03ee
Reneable warnexpressions tests (#7331)
KevinRansom Aug 2, 2019
dbdca01
Build correct FSharp.Core version number
KevinRansom Aug 2, 2019
9add797
remove auto-preview (#7344)
KevinRansom Aug 2, 2019
4b21f81
Update fsharp.core nuget package numbers (#7345)
KevinRansom Aug 3, 2019
1b879b1
Use GetFullPath when determining the full path in handling command li…
cartermp Aug 9, 2019
4c88e27
pull all unit test assemblies from NuGet packages (#7378)
brettfo Aug 10, 2019
e12f8dc
Move nameof to preview (#7391)
KevinRansom Aug 13, 2019
1c6e820
Allow consuming visible fields and items we have an IVT for with open…
cartermp Aug 16, 2019
650a166
Open static classes in preview (#7414)
TIHan Aug 16, 2019
8dd81c6
Added inref immutability assumption removal (#7407)
TIHan Aug 20, 2019
9f51ac5
Opt out of PLM (partial load mode) (#7432)
TIHan Aug 21, 2019
dc8bc8d
Enums are always read-only (#7434)
TIHan Aug 22, 2019
9a9aead
LOC CHECKIN | dotnet/fsharp release/dev16.3 | 20190829
v-zbsail Aug 29, 2019
2959506
update package feed url (#7468)
brettfo Aug 29, 2019
256341a
Merge pull request #7465 from v-zbsail/loc_20190829_release_dev16.3
brettfo Aug 29, 2019
0422ff2
IMAGE_DEBUG_TYPE_CHECKSUMPDB version in pdb writer (#7443) (#7444)
brettfo Sep 5, 2019
6798df3
pull all unit test assemblies from NuGet packages (#7378)
brettfo Aug 10, 2019
2b4eea2
Merge pull request #7424 from brettfo/package-restore
brettfo Aug 20, 2019
48ec682
remove package restore hack and don't allow package fallback folders …
brettfo Aug 21, 2019
ffc2d2f
Fix #5729 (#6352)
gdziadkiewicz Aug 21, 2019
9e73d5e
Update dependencies from https://github.com/dotnet/arcade build 20190…
Aug 14, 2019
b6da336
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 16, 2019
d93aac6
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 17, 2019
e2fbfeb
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 20, 2019
2cb4d5d
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 21, 2019
9ab2e77
Merge pull request #7399 from dotnet/darc-master-8677af5b-d393-44df-8…
mmitche Aug 21, 2019
794e4ab
add FSharp.Compiler.Scripting (#7437)
brettfo Aug 23, 2019
1e6fb85
IMAGE_DEBUG_TYPE_CHECKSUMPDB version in pdb writer (#7443)
chuckries Aug 23, 2019
d4155a6
[master] Update dependencies from dotnet/arcade (#7438)
dotnet-maestro[bot] Aug 24, 2019
5778a64
FCS Doc update - SourceText (#7446)
0x6a62 Aug 24, 2019
33de876
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 24, 2019
9f4ded7
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 25, 2019
d58bfc4
Merge pull request #7449 from dotnet/darc-master-b777ffc0-5c64-490d-8…
mmitche Aug 25, 2019
697fedd
Fix #3113 by porting the relevant roslyn codeand integrate it into th…
matthid Aug 26, 2019
3742740
update package feed url (#7459)
brettfo Aug 28, 2019
20ab6da
* #6928 - Removed SByte and Byte from default case requirement and ad…
gdziadkiewicz Aug 29, 2019
5030e29
Dynamic compiling in Unity Player (2019.1.6f1) (#7427)
JanWosnitza Aug 29, 2019
c480289
Fix native resource issue with emptry streams
KevinRansom Aug 29, 2019
4d6e769
Update src/absil/cvtres.fs
KevinRansom Aug 29, 2019
25cf292
Merge pull request #7461 from KevinRansom/cvtres
KevinRansom Aug 29, 2019
589bbbb
Fix record pattern ranges (#7471)
auduchinok Aug 30, 2019
d982322
[master] Update dependencies from dotnet/arcade (#7452)
dotnet-maestro[bot] Sep 1, 2019
01e02b5
fix documentation typos (#7420)
0x6a62 Sep 2, 2019
c6ee3d2
cleanup cvtres.fs (#7476)
dsyme Sep 3, 2019
6a4ba7f
--standalone type forwarding (#7462)
KevinRansom Sep 4, 2019
997d016
Remove FX_NO_LINKED_RESOURCES (#7480)
KevinRansom Sep 4, 2019
8e044aa
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 4, 2019
88911b9
Disallow attributes on type extensions (#7481)
nelson-wu Sep 4, 2019
78cd5d2
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 5, 2019
44ec439
add VS insertion logic to build pipeline (#7500)
brettfo Sep 5, 2019
c8b5712
add doc with links to all internal build definitions, etc. (#7505)
brettfo Sep 6, 2019
5b12870
Fix ctrl - c handling on the coreclr (#7495)
KevinRansom Sep 6, 2019
c11b9d1
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 6, 2019
2a24020
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 6, 2019
f28daf0
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 7, 2019
f9f6027
Add a missing word to the comment (#7517)
ForNeVeR Sep 7, 2019
60074cb
[master] Update dependencies from dotnet/arcade (#7522)
dotnet-maestro[bot] Sep 9, 2019
5d2bd22
cleanup FX_LCIDFROMCODEPAGE (#7509)
KevinRansom Sep 9, 2019
0a6cf6f
cleanup compilingFsLib (#7510)
KevinRansom Sep 9, 2019
f2d1686
Remove Dead code --- BigInteger (#7511)
KevinRansom Sep 9, 2019
f06e0ac
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 10, 2019
a18c253
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 11, 2019
71b3830
Merge pull request #7535 from dotnet/darc-master-028c1ccd-912d-4623-9…
brettfo Sep 11, 2019
f5d1499
Minor cleanup, do not check assembly for string concat optimization (…
TIHan Sep 11, 2019
44ca3eb
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 12, 2019
1bea321
FX_NO_SYSTEM_CONSOLE and EXTRAS_FOR_SILVERLIGHT_COMPILER are never se…
KevinRansom Sep 13, 2019
2c4ed90
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 13, 2019
92a5b36
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 16, 2019
d6afc7b
fire events when script host resolves assembly reference (#7571)
brettfo Sep 17, 2019
b18cb9d
update insert task to v3 (#7574)
brettfo Sep 17, 2019
b7c486c
Remove the requirement for explicit FSharp.Core reference need --nofr…
KevinRansom Sep 18, 2019
d6b5b1b
Re-enable magic-resolver in fsi for coreclr (#7598)
KevinRansom Sep 19, 2019
912b2d3
Merge remote-tracking branch 'upstream/release/dev16.3' into merges/r…
brettfo Sep 23, 2019
d12b732
Merge pull request #7611 from dotnet/merges/release/dev16.3-to-master
brettfo Sep 24, 2019
62e5dd8
relax multiple load objection (#7613)
KevinRansom Sep 24, 2019
495dc77
Relax --noframework for mscorlib, netstandard and system.runtime (#7612)
KevinRansom Sep 24, 2019
bb9d4b9
add build telemetry for Linux/MacOS builds
brettfo Sep 26, 2019
837c6cb
Merge pull request #7638 from brettfo/build-telemetry
KevinRansom Sep 26, 2019
04d4c51
add workspace and diagnostics to lsp (#7006)
brettfo Sep 27, 2019
9adbbe8
Less subsequent filtering in completion (#7650)
auduchinok Sep 27, 2019
c1d6fc8
Make ILPreTypeDef interface (#7649)
auduchinok Sep 27, 2019
2328612
Add FSharpDisplayContext.WithShortTypeNames(bool) (#7651)
auduchinok Sep 27, 2019
93df95a
replace deprecated nuspec `iconUrl` element with `icon`
brettfo Sep 27, 2019
ce11921
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 26, 2019
168bcfb
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 27, 2019
d54d110
Merge remote-tracking branch 'upstream/darc-master-ccc2f9a8-8c49-40d2…
brettfo Sep 27, 2019
004ffcf
Merge pull request #7655 from brettfo/package-icon
brettfo Sep 27, 2019
699cb0d
update RELEASE_NOTES and README with versions
baronfel Sep 30, 2019
d348d6a
Fix release notes so they are happier
baronfel Sep 30, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@
targets.make text eol=lf

*.bsl linguist-vendored=true

*.png binary
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ tests/fsharpqa/Source/*FSharpQA_Failures.lst
FSharp.Compiler.Tools.Nuget/*.nupkg
FSharp.Core.Nuget/*.nupkg
artifacts/*.nupkg
*.bak
*.vserr
*.err
*.orig
*.mdf
*.ldf
Expand Down Expand Up @@ -221,7 +224,6 @@ source_link.json
System.ValueTuple.dll
tests/fsharpqa/testenv/bin/System.ValueTuple.dll
lib/netcore/fsc/bin/

!lib/bootstrap/signed/**/*
*/.fake
/fcs/packages/
Expand Down
19 changes: 0 additions & 19 deletions FSharp.Profiles.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,42 +6,23 @@
<DefineConstants Condition="'$(MonoPackaging)' == 'true'">$(DefineConstants);CROSS_PLATFORM_COMPILER</DefineConstants>
<DefineConstants>$(DefineConstants);ENABLE_MONO_SUPPORT</DefineConstants>
<DefineConstants>$(DefineConstants);BE_SECURITY_TRANSPARENT</DefineConstants>
<DefineConstants>$(DefineConstants);FX_LCIDFROMCODEPAGE</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard')) OR $(TargetFramework.StartsWith('netcoreapp'))">
<DefineConstants>$(DefineConstants);NETSTANDARD</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_APP_DOMAINS</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_ARRAY_LONG_LENGTH</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_BEGINEND_READWRITE</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_BINARY_SERIALIZATION</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_CONVERTER</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_DEFAULT_DEPENDENCY_TYPE</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_CORHOST_SIGNER</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_EVENTWAITHANDLE_IDISPOSABLE</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_EXIT_CONTEXT_FLAGS</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_LINKEDRESOURCES</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_PARAMETERIZED_THREAD_START</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_PDB_READER</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_PDB_WRITER</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_REFLECTION_MODULE_HANDLES</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_REFLECTION_ONLY</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_RUNTIMEENVIRONMENT</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_SECURITY_PERMISSIONS</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_SERVERCODEPAGES</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_SYMBOLSTORE</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_SYSTEM_CONFIGURATION</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_THREAD</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_THREADABORT</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_WAITONE_MILLISECONDS</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_WEB_CLIENT</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_WIN_REGISTRY</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_WINFORMS</DefineConstants>
<DefineConstants>$(DefineConstants);FX_NO_INDENTED_TEXT_WRITER</DefineConstants>
<DefineConstants>$(DefineConstants);FX_REDUCED_EXCEPTIONS</DefineConstants>
<DefineConstants>$(DefineConstants);FX_RESHAPED_REFEMIT</DefineConstants>
<DefineConstants>$(DefineConstants);FX_RESHAPED_GLOBALIZATION</DefineConstants>
<DefineConstants>$(DefineConstants);FX_RESHAPED_REFLECTION</DefineConstants>
<DefineConstants>$(DefineConstants);FX_RESHAPED_MSBUILD</DefineConstants>
<OtherFlags>$(OtherFlags) --simpleresolution</OtherFlags>
</PropertyGroup>
Expand Down
4 changes: 4 additions & 0 deletions FSharpBuild.Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(OS)' == 'Unix'">
<DefineConstants>$(DefineConstants);TESTING_ON_LINUX</DefineConstants>
</PropertyGroup>

<!-- SDK targets override -->
<PropertyGroup Condition="'$(Configuration)' != 'Proto' AND '$(DisableCompilerRedirection)'!='true' AND Exists('$(ProtoOutputPath)')">
<FSharpTargetsPath>$(ProtoOutputPath)\fsc\Microsoft.FSharp.Targets</FSharpTargetsPath>
Expand Down
60 changes: 60 additions & 0 deletions INTERNAL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
# Links for internal team members to find build definitions, etc.

Note that usually only the most recent link in each section is interesting. Older links are included for reference only.

## PR Build Definition

The PR build definition can be found [here](https://dev.azure.com/dnceng/public/_build?definitionId=496) or by
navigating through an existing PR.

## Signed Build Definitions

[VS 16.4 to current](https://dev.azure.com/dnceng/internal/_build?definitionId=499&_a=summary)

[VS 15.7 to 16.3](https://dev.azure.com/devdiv/DevDiv/_build/index?definitionId=8978)

[VS 15.6](https://dev.azure.com/devdiv/DevDiv/_build?definitionId=7239)

[VS 15.0 to 15.5](https://dev.azure.com/devdiv/DevDiv/_build?definitionId=5037)

## VS Insertion Generators

VS 16.4 to current - part of the build definition. [See below](#vs-insertions-as-part-of-the-build-definition).

The following insertion generators are automatically invoked upon successful completion of a signed build in each of
their respective branches.

[VS 16.3](https://dev.azure.com/devdiv/DevDiv/_release?definitionId=1839&_a=releases)

[VS 16.2](https://dev.azure.com/devdiv/DevDiv/_release?definitionId=1699&_a=releases)

[VS 16.1](https://dev.azure.com/devdiv/DevDiv/_release?definitionId=1669&_a=releases)

VS 16.0 and prior were done manually

## VS Insertions as part of the build definition

Starting with the 16.4 release and moving forwards, the VS insertion is generated as part of the build. The relevant
bits can be found near the bottom of [`azure-pipelines.yml`](azure-pipelines.yml) under the `VS Insertion` header. The
interesting parameters are `componentBranchName` and `insertTargetBranch`. In short, when an internal signed build
completes and the name of the branch built exactly equals the value in the `componentBranchName` parameter, a component
insertion into VS will be created into the `insertTargetBranch` branch. The link to the insertion PR will be found
near the bottom of the build under the title 'Insert into VS'. Examine the log for 'Insert VS Payload' and near the
bottom you'll see a line that looks like `Created request #xxxxxx at https://...`.

To see all insertions created this way (possibly including for other internal teams), check
[here](https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequests?creatorId=122d5278-3e55-4868-9d40-1e28c2515fc4&_a=active).

## Less interesting links

[Nightly VSIX (master) uploader](https://dev.azure.com/dnceng/internal/_release?_a=releases&definitionId=70). Uploads
a package from every build of `master` to the [Nightly VSIX feed](README.md#using-nightly-releases-in-visual-studio).

[Nightly VSIX (preview) uploader](https://dev.azure.com/dnceng/internal/_release?_a=releases&definitionId=71). Uploads
a package from every build of the branch that corresponds to the current Visual Studio preview to the
[Preview VSIX feed](README.md#using-nightly-releases-in-visual-studio).

[MyGet package uploader](https://dev.azure.com/dnceng/internal/_release?_a=releases&definitionId=69). Uploads various
packages for internal consumption. Feed URL is `https://dotnet.myget.org/F/fsharp/api/v3/index.json`.

[Internal source mirror](https://dev.azure.com/dnceng/internal/_git/dotnet-fsharp).
8 changes: 5 additions & 3 deletions NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@
<add key="interactive-window" value="https://dotnet.myget.org/F/interactive-window/api/v3/index.json" />
<add key="vs-devcore" value="https://myget.org/F/vs-devcore/api/v3/index.json" />
<add key="vs-editor" value="https://myget.org/F/vs-editor/api/v3/index.json" />
<add key="vssdk" value="https://vside.myget.org/F/vssdk/api/v3/index.json" />
<add key="vs-impl" value="https://vside.myget.org/F/vs-impl/api/v3/index.json" />
<add key="vssdk" value="https://pkgs.dev.azure.com/azure-public/vside/_packaging/vssdk/nuget/v3/index.json" />
<add key="vs-impl" value="https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json" />
<add key="roslyn_concord" value="https://myget.org/F/roslyn_concord/api/v3/index.json" />
<add key="devcore" value="https://vside.myget.org/F/devcore/api/v3/index.json" />
<add key="dotnet-windowsdesktop" value="https://dotnetfeed.blob.core.windows.net/dotnet-windowsdesktop/index.json" />
<add key="aspnet-aspnetcore" value="https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore/index.json" />
<add key="aspnet-aspnetcore-tooling" value="https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore-tooling/index.json" />
Expand All @@ -32,4 +31,7 @@
<disabledPackageSources>
<clear />
</disabledPackageSources>
<fallbackPackageFolders>
<clear />
</fallbackPackageFolders>
</configuration>
3 changes: 3 additions & 0 deletions eng/Build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ function BuildSolution() {
/p:QuietRestore=$quietRestore `
/p:QuietRestoreBinaryLog=$binaryLog `
/p:TestTargetFrameworks=$testTargetFrameworks `
/v:$verbosity `
$suppressExtensionDeployment `
@properties
}
Expand Down Expand Up @@ -337,6 +338,7 @@ try {
if ($testDesktop -and -not $noVisualStudio) {
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.UnitTests\FSharp.Compiler.UnitTests.fsproj" -targetFramework $desktopTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.LanguageServer.UnitTests\FSharp.Compiler.LanguageServer.UnitTests.fsproj" -targetFramework $desktopTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.Private.Scripting.UnitTests\FSharp.Compiler.Private.Scripting.UnitTests.fsproj" -targetFramework $desktopTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Build.UnitTests\FSharp.Build.UnitTests.fsproj" -targetFramework $desktopTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Core.UnitTests\FSharp.Core.UnitTests.fsproj" -targetFramework $desktopTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\fsharp\FSharpSuite.Tests.fsproj" -targetFramework $desktopTargetFramework
Expand All @@ -345,6 +347,7 @@ try {
if ($testCoreClr) {
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.UnitTests\FSharp.Compiler.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.LanguageServer.UnitTests\FSharp.Compiler.LanguageServer.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.Private.Scripting.UnitTests\FSharp.Compiler.Private.Scripting.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Build.UnitTests\FSharp.Build.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Core.UnitTests\FSharp.Core.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
TestUsingNUnit -testProject "$RepoRoot\tests\fsharp\FSharpSuite.Tests.fsproj" -targetFramework $coreclrTargetFramework
Expand Down
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<ProductDependencies>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19410.2">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.19476.6">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>e2f5f0f5c20a1fef71845795b09066a5cd892a7e</Sha>
<Sha>b449f372df1a3374ebdc85f42ff137dcda08776b</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
21 changes: 12 additions & 9 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,25 @@
<!-- Version number computation -->
<PropertyGroup>
<PreReleaseVersionLabel>beta</PreReleaseVersionLabel>
<FSLanguageVersion>4.6</FSLanguageVersion>
<FSLanguageVersion>4.7</FSLanguageVersion>
<FSCoreMajorVersion>$(FSLanguageVersion)</FSCoreMajorVersion>
<FSCorePackageVersion>$(FSCoreMajorVersion).3</FSCorePackageVersion>
<FSCorePackageVersion>$(FSCoreMajorVersion).1</FSCorePackageVersion>
<FSCoreVersionPrefix>$(FSCoreMajorVersion).0</FSCoreVersionPrefix>
<FSCoreVersion>$(FSCoreVersionPrefix).0</FSCoreVersion>
<!-- The current published nuget package -->
<FSharpCoreShippedPackageVersion>4.6.2</FSharpCoreShippedPackageVersion>
<FSharpCoreShippedPackageVersion>4.7.0</FSharpCoreShippedPackageVersion>
<!-- The pattern for specifying the preview package -->
<FSharpCorePreviewPackageVersion>$(FSCorePackageVersion)-$(PreReleaseVersionLabel).*</FSharpCorePreviewPackageVersion>
</PropertyGroup>
<PropertyGroup>
<FSPackageMajorVersion>10.5</FSPackageMajorVersion>
<FSPackageMajorVersion>10.6</FSPackageMajorVersion>
<FSPackageVersion>$(FSPackageMajorVersion).0</FSPackageVersion>
<FSProductVersionPrefix>$(FSPackageVersion)</FSProductVersionPrefix>
<FSProductVersion>$(FSPackageVersion).0</FSProductVersion>
</PropertyGroup>
<PropertyGroup>
<VSMajorVersion>16</VSMajorVersion>
<VSMinorVersion>2</VSMinorVersion>
<VSMinorVersion>3</VSMinorVersion>
<VSGeneralVersion>$(VSMajorVersion).0</VSGeneralVersion>
<VSAssemblyVersionPrefix>$(VSMajorVersion).$(VSMinorVersion).0</VSAssemblyVersionPrefix>
<VSAssemblyVersion>$(VSAssemblyVersionPrefix).0</VSAssemblyVersion>
Expand All @@ -55,15 +55,13 @@
https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json;
https://api.nuget.org/v3/index.json;
https://dotnet.myget.org/F/roslyn/api/v3/index.json;
https://dotnet.myget.org/F/roslyn-analyzers/api/v3/index.json;
https://dotnet.myget.org/F/symreader-converter/api/v3/index.json;
https://dotnet.myget.org/F/interactive-window/api/v3/index.json;
https://myget.org/F/vs-devcore/api/v3/index.json;
https://myget.org/F/vs-editor/api/v3/index.json;
https://vside.myget.org/F/vssdk/api/v3/index.json;
https://vside.myget.org/F/vs-impl/api/v3/index.json;
https://pkgs.dev.azure.com/azure-public/vside/_packaging/vssdk/nuget/v3/index.json;
https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json;
https://myget.org/F/roslyn_concord/api/v3/index.json;
https://vside.myget.org/F/devcore/api/v3/index.json;
</RestoreSources>
<!-- version numbers from files -->
<RoslynVersion>$([System.IO.File]::ReadAllText('$(MSBuildThisFileDirectory)..\RoslynPackageVersion.txt').Trim())</RoslynVersion>
Expand Down Expand Up @@ -116,6 +114,8 @@
<MicrosoftVisualStudioComponentModelHostVersion>16.1.89</MicrosoftVisualStudioComponentModelHostVersion>
<MicrosoftVisualStudioDesignerInterfacesVersion>1.1.4322</MicrosoftVisualStudioDesignerInterfacesVersion>
<MicrosoftVisualStudioEditorVersion>16.1.89</MicrosoftVisualStudioEditorVersion>
<MicrosoftVisualStudioEditorImplementationVersion>16.1.89</MicrosoftVisualStudioEditorImplementationVersion>
<MicrosoftVisualStudioGraphModelVersion>16.0.28226-alpha</MicrosoftVisualStudioGraphModelVersion>
<MicrosoftVisualStudioImageCatalogVersion>16.1.28916.169</MicrosoftVisualStudioImageCatalogVersion>
<MicrosoftVisualStudioImagingVersion>16.1.28917.181</MicrosoftVisualStudioImagingVersion>
<MicrosoftVisualStudioLanguageServerClientVersion>16.1.3121</MicrosoftVisualStudioLanguageServerClientVersion>
Expand All @@ -125,6 +125,7 @@
<MicrosoftVisualStudioManagedInterfacesVersion>8.0.50728</MicrosoftVisualStudioManagedInterfacesVersion>
<MicrosoftVisualStudioOLEInteropVersion>7.10.6071</MicrosoftVisualStudioOLEInteropVersion>
<MicrosoftVisualStudioPackageLanguageService150Version>16.1.28917.181</MicrosoftVisualStudioPackageLanguageService150Version>
<MicrosoftVisualStudioPlatformVSEditorVersion>16.1.89</MicrosoftVisualStudioPlatformVSEditorVersion>
<MicrosoftVisualStudioProjectAggregatorVersion>8.0.50728</MicrosoftVisualStudioProjectAggregatorVersion>
<MicrosoftVisualStudioProjectSystemVersion>16.0.201-pre-g7d366164d0</MicrosoftVisualStudioProjectSystemVersion>
<MicrosoftVisualStudioProjectSystemManagedVersion>2.3.6152103</MicrosoftVisualStudioProjectSystemManagedVersion>
Expand All @@ -141,7 +142,9 @@
<MicrosoftVisualStudioShellInterop100Version>10.0.30320</MicrosoftVisualStudioShellInterop100Version>
<MicrosoftVisualStudioShellInterop110Version>11.0.61031</MicrosoftVisualStudioShellInterop110Version>
<MicrosoftVisualStudioShellInterop120Version>12.0.30111</MicrosoftVisualStudioShellInterop120Version>
<MicrosoftVisualStudioShellInterop160DesignTimeVersion>16.0.0</MicrosoftVisualStudioShellInterop160DesignTimeVersion>
<MicrosoftVisualStudioTextDataVersion>16.1.89</MicrosoftVisualStudioTextDataVersion>
<MicrosoftVisualStudioTextInternalVersion>16.1.89</MicrosoftVisualStudioTextInternalVersion>
<MicrosoftVisualStudioTextManagerInteropVersion>7.10.6071</MicrosoftVisualStudioTextManagerInteropVersion>
<MicrosoftVisualStudioTextManagerInterop80Version>8.0.50728</MicrosoftVisualStudioTextManagerInterop80Version>
<MicrosoftVisualStudioTextManagerInterop100Version>10.0.30320</MicrosoftVisualStudioTextManagerInterop100Version>
Expand Down
23 changes: 19 additions & 4 deletions eng/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ function TestUsingNUnit() {
args="test \"$testproject\" --no-restore --no-build -c $configuration -f $targetframework --test-adapter-path . --logger \"nunit;LogFilePath=$testlogpath\""
"$DOTNET_INSTALL_DIR/dotnet" $args || {
local exit_code=$?
echo "dotnet test failed (exit code '$exit_code')." >&2
Write-PipelineTelemetryError -category 'Test' "dotnet test failed for $testproject:$targetframework (exit code $exit_code)."
ExitWithExitCode $exit_code
}
}
Expand Down Expand Up @@ -228,7 +228,11 @@ function BuildSolution {
MSBuild "$repo_root/src/buildtools/buildtools.proj" \
/restore \
/p:Configuration=$bootstrap_config \
/t:Publish
/t:Publish || {
local exit_code=$?
Write-PipelineTelemetryError -category 'Build' "Error building buildtools (exit code '$exit_code')."
ExitWithExitCode $exit_code
}

mkdir -p "$bootstrap_dir"
cp -pr $artifacts_dir/bin/fslex/$bootstrap_config/netcoreapp2.1/publish $bootstrap_dir/fslex
Expand All @@ -238,14 +242,19 @@ function BuildSolution {
MSBuild "$repo_root/proto.proj" \
/restore \
/p:Configuration=$bootstrap_config \
/t:Publish
/t:Publish || {
local exit_code=$?
Write-PipelineTelemetryError -category 'Build' "Error building bootstrap compiler (exit code '$exit_code')."
ExitWithExitCode $exit_code
}

cp -pr $artifacts_dir/bin/fsc/$bootstrap_config/netcoreapp2.1/publish $bootstrap_dir/fsc
fi

# do real build
MSBuild $toolset_build_proj \
$bl \
/v:$verbosity \
/p:Configuration=$configuration \
/p:Projects="$projects" \
/p:RepoRoot="$repo_root" \
Expand All @@ -258,7 +267,11 @@ function BuildSolution {
/p:ContinuousIntegrationBuild=$ci \
/p:QuietRestore=$quiet_restore \
/p:QuietRestoreBinaryLog="$binary_log" \
$properties
$properties || {
local exit_code=$?
Write-PipelineTelemetryError -category 'Build' "Error building solution (exit code '$exit_code')."
ExitWithExitCode $exit_code
}
}

InitializeDotNetCli $restore
Expand All @@ -272,8 +285,10 @@ if [[ "$test_core_clr" == true ]]; then
coreclrtestframework=netcoreapp3.0
TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.UnitTests/FSharp.Compiler.UnitTests.fsproj" --targetframework $coreclrtestframework
TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.LanguageServer.UnitTests/FSharp.Compiler.LanguageServer.UnitTests.fsproj" --targetframework $coreclrtestframework
TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharp.Compiler.Private.Scripting.UnitTests.fsproj" --targetframework $coreclrtestframework
TestUsingNUnit --testproject "$repo_root/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj" --targetframework $coreclrtestframework
TestUsingNUnit --testproject "$repo_root/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj" --targetframework $coreclrtestframework
fi

ExitWithExitCode 0

Loading