-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add option the popup to close on mouseleave #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option the popup to close on mouseleave #125
Conversation
Thank you! I’ll make sure it works correctly soon |
I made a change so that the popup close gets canceled if you re-mousenter quick enough, within 1 sec (1000 ms) |
Hi @fregante
|
@fregante Have you changed your mind? Do you find this PR is not salvageable? Should I close this? |
I've been on Safari for a year and I haven't used some of my extensions since 😅 so you can just leave this open until someone reviews it |
Welcome to contribute here: https://github.com/tjx666/github-notifications-preview/tree/main |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I just submitted this version to the chrome web store. They should publish it within 24 hours |
Closes #123
Test URLs
https://github.com/
Screenshot
Note to reviewers
I use
.removeAttribute('open')
to close the dropdown.