Fix missing parenthesis after applying XUnit code fixes #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meir017
reviewed
Dec 4, 2023
Meir017
approved these changes
Dec 8, 2023
|
@jairbubbles Thank you for your contribution! version |
|
Thanks, for your information I stumbled on https://github.com/meziantou/Meziantou.FluentAssertionsAnalyzers which also supports NUnit test migration. Also, one cool thing is that the code fixes are already reported on a same ID so it's easier to fix all at once: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After applying code fixes to transform XUnit asserts to fluent assertions I got some compilation errors. Some parenthesis were missing when the expression tested was complex.
Note: The tests were not properly testing the code source after the code fix is applied, I re-enabled it but some tests were failing so I added a
'#if TO_BE_FIXED