-
Notifications
You must be signed in to change notification settings - Fork 1.4k
winsvc: Fix bug where service accidentally stops after starting #4954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winsvc: Fix bug where service accidentally stops after starting #4954
Conversation
1097568
to
dd83b9e
Compare
dd83b9e
to
769ec5b
Compare
I do not understand why this trace log is marked as Error. https://github.com/fluent/fluentd/actions/runs/14992579391/job/42119227188?pr=4954#step:5:97
|
The fails of Windows tests with Ruby 3.2 and 3.3 have nothing to do with this fix. |
It appears that GitHub responds to the https://github.com/daipom/test-ci/actions/runs/14994067883/job/42124023183
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After 53bcd3c (fluent#4909), the service accidentally stops after starting, without stopping the supervisor and workers. Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Takuro Ashie <[email protected]> Co-authored-by: Kentaro Hayashi <[email protected]>
769ec5b
to
86b576b
Compare
Thanks for your review! |
**Which issue(s) this PR fixes**: This fixes a bug of #4909. **What this PR does / why we need it**: After 53bcd3c (#4909), the service accidentally stops after starting, without stopping the supervisor and workers. **Docs Changes**: Not needed. **Release Note**: The same as the title. Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Takuro Ashie <[email protected]> Co-authored-by: Kentaro Hayashi <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]>
**Which issue(s) this PR fixes**: This fixes a bug of #4909. **What this PR does / why we need it**: After 53bcd3c (#4909), the service accidentally stops after starting, without stopping the supervisor and workers. **Docs Changes**: Not needed. **Release Note**: The same as the title. Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Takuro Ashie <[email protected]> Co-authored-by: Kentaro Hayashi <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]>
**Which issue(s) this PR fixes**: This fixes a bug of #4909. **What this PR does / why we need it**: After 53bcd3c (#4909), the service accidentally stops after starting, without stopping the supervisor and workers. **Docs Changes**: Not needed. **Release Note**: The same as the title. Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Takuro Ashie <[email protected]> Co-authored-by: Kentaro Hayashi <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]>
…er starting (#4954) (#4955) **Which issue(s) this PR fixes**: Backport #4954. **What this PR does / why we need it**: After 53bcd3c (#4909), the service accidentally stops after starting, without stopping the supervisor and workers. **Docs Changes**: Not needed. **Release Note**: The same as the title. Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Takuro Ashie <[email protected]> Co-authored-by: Kentaro Hayashi <[email protected]>
Which issue(s) this PR fixes:
This fixes a bug of #4909.
What this PR does / why we need it:
After 53bcd3c (#4909), the service accidentally stops after starting, without stopping the supervisor and workers.
Docs Changes:
Not needed.
Release Note:
The same as the title.Not needed for v1.19 because #4909 has not been released in the normal version yet.