Skip to content

Conversation

daipom
Copy link
Contributor

@daipom daipom commented May 13, 2025

Which issue(s) this PR fixes:
This fixes a bug of #4909.

What this PR does / why we need it:
After 53bcd3c (#4909), the service accidentally stops after starting, without stopping the supervisor and workers.

Docs Changes:
Not needed.

Release Note:
The same as the title.
Not needed for v1.19 because #4909 has not been released in the normal version yet.

@daipom daipom added this to the v1.19.0 milestone May 13, 2025
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label May 13, 2025
@daipom daipom force-pushed the win32-service-fix-bug-with-launching branch 5 times, most recently from 1097568 to dd83b9e Compare May 13, 2025 08:54
@daipom daipom force-pushed the win32-service-fix-bug-with-launching branch from dd83b9e to 769ec5b Compare May 13, 2025 09:02
@daipom
Copy link
Contributor Author

daipom commented May 13, 2025

I do not understand why this trace log is marked as Error.
However, it does not seem to affect the test.
I have confirmed that if there is a matching log, the test enters the if statement as expected, and the test fails.

https://github.com/fluent/fluentd/actions/runs/14992579391/job/42119227188?pr=4954#step:5:97

Error: DEBUG: 26+ if ( >>>> Select-String -Path $_ -Pattern "[warn]", "[error]", "[fatal]" -SimpleMatch -Quiet) {

@daipom
Copy link
Contributor Author

daipom commented May 13, 2025

The fails of Windows tests with Ruby 3.2 and 3.3 have nothing to do with this fix.

@daipom
Copy link
Contributor Author

daipom commented May 13, 2025

I do not understand why this trace log is marked as Error. However, it does not seem to affect the test. I have confirmed that if there is a matching log, the test enters the if statement as expected, and the test fails.

https://github.com/fluent/fluentd/actions/runs/14992579391/job/42119227188?pr=4954#step:5:97

Error: DEBUG: 26+ if ( >>>> Select-String -Path $_ -Pattern "[warn]", "[error]", "[fatal]" -SimpleMatch -Quiet) {

It appears that GitHub responds to the [error] string, and it has nothing to do with the PowerShell process.
We can ignore this.

https://github.com/daipom/test-ci/actions/runs/14994067883/job/42124023183

$ErrorActionPreference = "Stop"
Set-PSDebug -Trace 1

"error" | Out-Null
"[error]" | Out-Null
"error" | Out-Null
DEBUG:    4+  >>>> "error" | Out-Null

Error: DEBUG:    5+  >>>> "[error]" | Out-Null

DEBUG:    6+  >>>> "error" | Out-Null

DEBUG:    3+ if ( >>>> (Test-Path -LiteralPath variable:\LASTEXITCODE)) { exit $LASTEXITCODE }

ashie
ashie previously approved these changes May 14, 2025
Copy link
Member

@ashie ashie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

After 53bcd3c (fluent#4909), the service
accidentally stops after starting, without stopping the supervisor and
workers.

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Takuro Ashie <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
@daipom daipom force-pushed the win32-service-fix-bug-with-launching branch from 769ec5b to 86b576b Compare May 14, 2025 02:02
@daipom daipom requested a review from kenhys May 14, 2025 02:50
@daipom daipom merged commit efbb51d into fluent:master May 14, 2025
9 of 13 checks passed
@daipom
Copy link
Contributor Author

daipom commented May 14, 2025

Thanks for your review!

@daipom daipom deleted the win32-service-fix-bug-with-launching branch May 14, 2025 06:22
daipom added a commit that referenced this pull request May 14, 2025
**Which issue(s) this PR fixes**:
This fixes a bug of #4909.

**What this PR does / why we need it**:
After 53bcd3c (#4909), the service
accidentally stops after starting, without stopping the supervisor and
workers.

**Docs Changes**:
Not needed.

**Release Note**:
The same as the title.

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Takuro Ashie <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom added a commit that referenced this pull request May 14, 2025
**Which issue(s) this PR fixes**:
This fixes a bug of #4909.

**What this PR does / why we need it**:
After 53bcd3c (#4909), the service
accidentally stops after starting, without stopping the supervisor and
workers.

**Docs Changes**:
Not needed.

**Release Note**:
The same as the title.

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Takuro Ashie <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom added the backported "backport to LTS" is done label May 14, 2025
daipom added a commit that referenced this pull request May 14, 2025
**Which issue(s) this PR fixes**:
This fixes a bug of #4909.

**What this PR does / why we need it**:
After 53bcd3c (#4909), the service
accidentally stops after starting, without stopping the supervisor and
workers.

**Docs Changes**:
Not needed.

**Release Note**:
The same as the title.

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Takuro Ashie <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom added a commit that referenced this pull request May 14, 2025
…er starting (#4954) (#4955)

**Which issue(s) this PR fixes**:
Backport #4954.

**What this PR does / why we need it**:
After 53bcd3c (#4909), the service
accidentally stops after starting, without stopping the supervisor and
workers.

**Docs Changes**:
Not needed.

**Release Note**:
The same as the title.

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Takuro Ashie <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants