Use JSON instead of Yajl to improve performance of store/load files #4759
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shizuo Fujita <[email protected]>
This was referenced Jan 31, 2025
|
NOTE: will not be backported to v1.16 |
daipom
pushed a commit
that referenced
this pull request
Feb 3, 2025
…nce (#4813) **Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Recently, Ruby's json has incredible performance improvements. It might be faster than oj gem. So, I think json is a suitable as fallback. This is similar with #4759 Here is easily benchmark. (I used same log file in #4759) * Before * It spent 90.50963662 sec to handle 10 GB file * After * It spent 74.624230077 sec to handle 10 GB file * config ``` <source> @type tail path "#{File.expand_path '~/tmp/access*.log'}" pos_file "#{File.expand_path '~/tmp/fluentd/access.log.pos'}" tag log read_from_head true <parse> @type json </parse> </source> <match **> @type file path "#{File.expand_path '~/tmp/fluentd/log'}" </match> ``` FYI) * https://byroot.github.io/ruby/json/2024/12/15/optimizing-ruby-json-part-1.html * https://byroot.github.io/ruby/json/2024/12/18/optimizing-ruby-json-part-2.html * https://byroot.github.io/ruby/json/2024/12/27/optimizing-ruby-json-part-3.html * https://byroot.github.io/ruby/json/2024/12/29/optimizing-ruby-json-part-4.html * https://byroot.github.io/ruby/json/2025/01/04/optimizing-ruby-json-part-5.html * https://byroot.github.io/ruby/json/2025/01/12/optimizing-ruby-json-part-6.html * https://byroot.github.io/ruby/json/2025/01/14/optimizing-ruby-json-part-7.html **Docs Changes**: fluent/fluentd-docs-gitbook#560 **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
When I read 10 GB file using in_tail plugin, it calls Yajl methods many times when it stores to buffer file.
Recently, Ruby's JSON has huge improvement and it is much faster.
Ref. https://byroot.github.io/ruby/json/2024/12/15/optimizing-ruby-json-part-1.html
Before
After
config
Docs Changes:
Release Note: