Add discriminant method to fmpz_poly, fmpq_poly, nmod_poly #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Could you add a release note for 0.9.0 in the README? |
remyoudompheng
force-pushed
the
discriminant
branch
from
728d0a0 to
d26eb2c
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
discriminantmethod to all polynomial classes which already have theresultantmethod.It modifies fmpz_poly, fmpq_poly and nmod_poly (fmpz_mod_poly already has a discriminant method).
Note that for some reason the FLINT C library does not define a
fmpq_poly_discriminantmethod.