-
Notifications
You must be signed in to change notification settings - Fork 33
maint: bump cibuildwheel, mpfr and flint #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ef3372
to
31218df
Compare
The manylinux arm job is building too many wheels. Reported at pypa/cibuildwheel#2412 so I will leave this PR open as a demonstration and make a new separate PR to fix the Cython version. |
pyproject.toml
Outdated
# requires-python needs to keep in sync with this and also the list of Python | ||
# versions the wheels are tested against in CI. | ||
build = "cp311-* cp312-* cp313-* cp313t-*" # pp311-*" | ||
build = "cp311-* cp312-* cp313-* cp313t-* cp314-* cp314t-* pp311-*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, cibuildwheels will only build what's possible given requires-python
.
I often find easier not to specify build
in the configuration but only setting skip
.
In this case, adding pp310-*
to the skip
config allows to drop the build
config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be better. The comment above notes the awkwardness.
skip = "*-win32 *-manylinux_i686 *-musllinux_*" | ||
|
||
# Enable building for free-threaded CPython builds | ||
enable = ["cpython-freethreading"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variable & toml setting are additive for enable
, it might be better to keep the static config in pyproject.toml
and only add cpython-prerelease in the workflow (you can also add a condition on tags if you don't want to forget to remove it before a release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I don't think I want to have cpython-prerelease there at all actually (now that I have already confirmed that it works). For a moment it seemed like a good way to keep up to date with changes in 3.14 but actually I think it would be better just to have a job that builds fresh rather than messing with the wheel building configuration.
a50ba32
to
44c8258
Compare
Okay, this has produced the expected number of wheels now:
Thanks @mayeut for your help! |
Bump version constraints for Cython 3.1.