-
Notifications
You must be signed in to change notification settings - Fork 2
feat(Playbook): Secret parameter #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for canarychecker canceled.
|
✅ Deploy Preview for flanksource-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces secret parameter support for playbooks with KMS encryption capabilities. It adds the ability to handle sensitive data like passwords and API keys securely by integrating with cloud KMS services.
Key changes:
- Added new
secret
parameter type for playbooks with KMS encryption - Added documentation for AWS KMS, Azure Key Vault, and GCP KMS connections
- Updated submodule references across multiple mission-control components
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
mission-control/docs/reference/playbooks/parameters.mdx | Added documentation for the new secret parameter type |
mission-control/docs/reference/connections/KMS/*.mdx | Created documentation pages for AWS KMS, Azure Key Vault, and GCP KMS connections |
mission-control/docs/guide/playbooks/concepts/sensitive-data.mdx | Added comprehensive guide on handling sensitive data in playbooks |
mission-control/docs/installation/_properties_mission_control.mdx | Added kmsConnection configuration property |
common/src/components/Fields.jsx | Added field definitions for KMS connection types |
modules/* | Updated submodule commits to incorporate KMS functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mission-control/docs/installation/_properties_mission_control.mdx
Outdated
Show resolved
Hide resolved
25de0cc
to
71067b7
Compare
cc9515d
to
4ab9d1b
Compare
or in the helm chart: | ||
|
||
```yaml | ||
kmsConnection: "connection://default/my-kms-key" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the setup guides for AWS/GCP for the creation of this key, and connection and the updates to the IAM binding needed.
This is also I think a post-setup task as it requires the ability to create the connection first
* KMS connections
4ab9d1b
to
d45f70b
Compare
resolves: #423