Skip to content

Conversation

adityathebe
Copy link
Member

  • KMS connections

resolves: #423

@adityathebe adityathebe requested a review from Copilot August 26, 2025 13:37
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for canarychecker canceled.

Name Link
🔨 Latest commit 11cfaa9
🔍 Latest deploy log https://app.netlify.com/projects/canarychecker/deploys/68c7a29aee13a20008ea3ef6

Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for flanksource-docs ready!

Name Link
🔨 Latest commit 11cfaa9
🔍 Latest deploy log https://app.netlify.com/projects/flanksource-docs/deploys/68c7a29afa504b0008e243a1
😎 Deploy Preview https://deploy-preview-424--flanksource-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

vercel bot commented Aug 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
docs Ready Ready Preview Sep 15, 2025 5:23am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces secret parameter support for playbooks with KMS encryption capabilities. It adds the ability to handle sensitive data like passwords and API keys securely by integrating with cloud KMS services.

Key changes:

  • Added new secret parameter type for playbooks with KMS encryption
  • Added documentation for AWS KMS, Azure Key Vault, and GCP KMS connections
  • Updated submodule references across multiple mission-control components

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
mission-control/docs/reference/playbooks/parameters.mdx Added documentation for the new secret parameter type
mission-control/docs/reference/connections/KMS/*.mdx Created documentation pages for AWS KMS, Azure Key Vault, and GCP KMS connections
mission-control/docs/guide/playbooks/concepts/sensitive-data.mdx Added comprehensive guide on handling sensitive data in playbooks
mission-control/docs/installation/_properties_mission_control.mdx Added kmsConnection configuration property
common/src/components/Fields.jsx Added field definitions for KMS connection types
modules/* Updated submodule commits to incorporate KMS functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

or in the helm chart:

```yaml
kmsConnection: "connection://default/my-kms-key"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the setup guides for AWS/GCP for the creation of this key, and connection and the updates to the IAM binding needed.

This is also I think a post-setup task as it requires the ability to create the connection first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playbook Secret Parameter
2 participants