Skip to content

Revert emulator overlay to allow import into g3 #9307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2025
Merged

Revert emulator overlay to allow import into g3 #9307

merged 4 commits into from
Oct 9, 2025

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Oct 8, 2025 •
edited
Loading

Reverts #8977. Use of innerHtml was preventing import.

This is for the console branch only.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3c823fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarkDuckworth MarkDuckworth changed the base branch from main to console October 8, 2025 20:25
@google-cla Google CLA
Copy link

google-cla bot commented Oct 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser188 kB188 kB-55 B (-0.0%)
    cordova161 kB161 kB-55 B (-0.0%)
    main144 kB144 kB-39 B (-0.0%)
    module188 kB188 kB-55 B (-0.0%)
    react-native161 kB161 kB-39 B (-0.0%)

  • @firebase/auth-cordova

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser161 kB161 kB-55 B (-0.0%)
    module161 kB161 kB-55 B (-0.0%)

  • @firebase/auth-web-extension

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser139 kB138 kB-55 B (-0.0%)
    main155 kB155 kB-41 B (-0.0%)
    module139 kB138 kB-55 B (-0.0%)

  • @firebase/auth/internal

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser198 kB198 kB-55 B (-0.0%)
    main169 kB169 kB-41 B (-0.0%)
    module198 kB198 kB-55 B (-0.0%)

  • @firebase/data-connect

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser21.3 kB21.3 kB-63 B (-0.3%)
    main23.6 kB23.5 kB-47 B (-0.2%)
    module21.3 kB21.3 kB-63 B (-0.3%)

  • @firebase/database

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser249 kB249 kB-59 B (-0.0%)
    main254 kB254 kB-43 B (-0.0%)
    module249 kB249 kB-59 B (-0.0%)

  • @firebase/database-compat/standalone

    TypeBase (0fd1eda)Merge (0b37059)Diff
    main366 kB366 kB-43 B (-0.0%)

  • @firebase/firestore

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser391 kB391 kB-62 B (-0.0%)
    main611 kB611 kB-44 B (-0.0%)
    module391 kB391 kB-62 B (-0.0%)
    react-native392 kB392 kB-67 B (-0.0%)

  • @firebase/firestore-lite

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser115 kB115 kB-63 B (-0.1%)
    main158 kB158 kB-44 B (-0.0%)
    module115 kB115 kB-63 B (-0.1%)
    react-native116 kB115 kB-63 B (-0.1%)

  • @firebase/functions

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser14.2 kB14.1 kB-60 B (-0.4%)
    main14.7 kB14.7 kB-44 B (-0.3%)
    module14.2 kB14.1 kB-60 B (-0.4%)

  • @firebase/storage

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser58.3 kB58.3 kB-58 B (-0.1%)
    main59.8 kB59.8 kB-42 B (-0.1%)
    module58.3 kB58.3 kB-58 B (-0.1%)

  • @firebase/util

    TypeBase (0fd1eda)Merge (0b37059)Diff
    browser29.1 kB23.5 kB-5.58 kB (-19.2%)
    main35.5 kB29.8 kB-5.69 kB (-16.0%)
    module29.1 kB23.5 kB-5.58 kB (-19.2%)

  • bundle

    34 size changes

    TypeBase (0fd1eda)Merge (0b37059)Diff
    auth (GoogleFBTwitterGitHubPopup)105 kB101 kB-4.35 kB (-4.1%)
    database (Append to a list of data)154 kB149 kB-4.37 kB (-2.8%)
    database (Filtering data)153 kB148 kB-4.36 kB (-2.9%)
    database (Listen for child events)169 kB165 kB-4.36 kB (-2.6%)
    database (Listen for value events + Detach listeners)169 kB165 kB-4.36 kB (-2.6%)
    database (Listen for value events)169 kB165 kB-4.36 kB (-2.6%)
    database (Read data once)168 kB164 kB-4.36 kB (-2.6%)
    database (Save data as transactions)171 kB167 kB-4.36 kB (-2.6%)
    database (Sort data)154 kB150 kB-4.36 kB (-2.8%)
    database (Write data)153 kB149 kB-4.36 kB (-2.9%)
    firestore (CSI Auto Indexing Disable and Delete)286 kB282 kB-4.36 kB (-1.5%)
    firestore (CSI Auto Indexing Enable)286 kB282 kB-4.36 kB (-1.5%)
    firestore (Persistence)318 kB314 kB-4.36 kB (-1.4%)
    firestore (Query Cursors)257 kB253 kB-4.36 kB (-1.7%)
    firestore (Query)255 kB250 kB-4.36 kB (-1.7%)
    firestore (Read data once)245 kB240 kB-4.36 kB (-1.8%)
    firestore (Read Write w Persistence)338 kB333 kB-4.36 kB (-1.3%)
    firestore (Realtime updates)245 kB241 kB-4.36 kB (-1.8%)
    firestore (Transaction)223 kB219 kB-4.36 kB (-2.0%)
    firestore (Write data)224 kB220 kB-4.36 kB (-1.9%)
    firestore-lite (Query Cursors)110 kB105 kB-4.36 kB (-4.0%)
    firestore-lite (Query)106 kB102 kB-4.36 kB (-4.1%)
    firestore-lite (Read data once)81.6 kB77.3 kB-4.36 kB (-5.3%)
    firestore-lite (Transaction)107 kB103 kB-4.36 kB (-4.1%)
    firestore-lite (Write data)91.1 kB86.8 kB-4.36 kB (-4.8%)
    functions (call)38.7 kB34.4 kB-4.36 kB (-11.3%)
    storage (getBytes)46.6 kB42.2 kB-4.36 kB (-9.4%)
    storage (getDownloadURL)48.7 kB44.3 kB-4.36 kB (-9.0%)
    storage (getMetadata)48.1 kB43.8 kB-4.36 kB (-9.1%)
    storage (list + listAll)47.5 kB43.2 kB-4.36 kB (-9.2%)
    storage (updateMetadata)48.4 kB44.0 kB-4.36 kB (-9.0%)
    storage (uploadBytes)53.2 kB48.9 kB-4.36 kB (-8.2%)
    storage (uploadBytesResumable)63.1 kB58.8 kB-4.36 kB (-6.9%)
    storage (uploadString)53.4 kB49.1 kB-4.36 kB (-8.2%)

  • firebase

    15 size changes

    TypeBase (0fd1eda)Merge (0b37059)Diff
    firebase-auth-compat.js142 kB138 kB-4.13 kB (-2.9%)
    firebase-auth-cordova.js139 kB134 kB-4.45 kB (-3.2%)
    firebase-auth-web-extension.js122 kB118 kB-4.45 kB (-3.6%)
    firebase-auth.js159 kB154 kB-4.46 kB (-2.8%)
    firebase-compat.js809 kB805 kB-4.21 kB (-0.5%)
    firebase-data-connect.js22.5 kB18.1 kB-4.46 kB (-19.8%)
    firebase-database-compat.js168 kB164 kB-4.14 kB (-2.5%)
    firebase-database.js192 kB187 kB-4.46 kB (-2.3%)
    firebase-firestore-compat.js348 kB343 kB-4.13 kB (-1.2%)
    firebase-firestore-lite.js138 kB134 kB-4.46 kB (-3.2%)
    firebase-firestore.js454 kB449 kB-4.46 kB (-1.0%)
    firebase-functions-compat.js14.8 kB10.7 kB-4.12 kB (-27.8%)
    firebase-functions.js19.5 kB15.1 kB-4.46 kB (-22.8%)
    firebase-storage-compat.js44.2 kB40.1 kB-4.13 kB (-9.3%)
    firebase-storage.js51.1 kB46.6 kB-4.46 kB (-8.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UCHcZL1DYp.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (207,435 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NEeZu2dAWl.html

@MarkDuckworth MarkDuckworth marked this pull request as ready for review October 9, 2025 14:08
@MarkDuckworth MarkDuckworth merged commit ff3a59e into console Oct 9, 2025
62 of 66 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/console-revert-emulator-overlay branch October 9, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@mansisampat mansisampat Awaiting requested review from mansisampat mansisampat is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

@maneesht maneesht Awaiting requested review from maneesht maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDuckworth @google-oss-bot @hsubox76