Skip to content

Bump Appium.WebDriver from 4.4.5 to 8.0.1 #17741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump Appium.WebDriver from 4.4.5 to 8.0.1 #17741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<PackageVersion Include="System.Text.Json" Version="9.0.9" />
<PackageVersion Include="System.IO.Hashing" Version="9.0.9" />
<PackageVersion Include="System.Threading.Tasks.Dataflow" Version="9.0.9" />
<PackageVersion Include="Appium.WebDriver" Version="4.4.5" />
<PackageVersion Include="Appium.WebDriver" Version="8.0.1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The Appium.WebDriver dependency update introduces breaking API changes, causing compilation failures in interaction tests that use removed types like WindowsElement and methods like FindElementByName().

  • Description: The update to Appium.WebDriver version 8.0.1 introduces breaking API changes. The interaction test suite relies on types and methods that have been removed in this new version. Specifically, code in tests/Files.InteractionTests/SessionManager.cs and tests/Files.InteractionTests/Helper/TestHelper.cs uses the WindowsElement type, the generic WindowsDriver&lt;T&gt;, and FindElementBy* methods. These incompatibilities will cause compilation failures, rendering the entire UI test suite inoperable.

  • Suggested fix: Update the code in the Files.InteractionTests project to be compatible with Appium.WebDriver 8.0.1. This involves replacing WindowsDriver&lt;WindowsElement&gt; with the non-generic WindowsDriver, using AppiumElement instead of WindowsElement or AppiumWebElement, and replacing FindElementBy*() methods with FindElement(AppiumBy.*).
    severity: 0.9, confidence: 1.0

Did we get this right? 👍 / 👎 to inform future reviews.

<PackageVersion Include="Axe.Windows" Version="2.4.2" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageVersion Include="MSTest.TestAdapter" Version="3.11.0" />
Expand Down
Loading