Skip to content

Conversation

gar1t
Copy link
Contributor

@gar1t gar1t commented Apr 30, 2024

Includes fix to typo in function name.

Ref: #447

Includes fix to typo in function name.

Ref: fastapi#447
@svlandeg svlandeg added bug Something isn't working p2 labels May 2, 2024
@svlandeg svlandeg linked an issue May 21, 2024 that may be closed by this pull request
7 tasks
svlandeg

This comment was marked as outdated.

@gar1t

This comment was marked as outdated.

@svlandeg

This comment was marked as outdated.

@gar1t

This comment was marked as outdated.

@svlandeg

This comment was marked as outdated.

@svlandeg svlandeg marked this pull request as draft June 3, 2024 08:35
@svlandeg svlandeg self-assigned this Aug 5, 2024
@svlandeg
Copy link
Member

svlandeg commented Sep 2, 2024

Update: I've solicited feedback from Tiangolo on PR #964 to first establish what the ideal output is for a variety of use-cases. This will help us better understand the changes proposed in this PR as well.

I know that some of these edits may seem straightforward, but as I was writing the additional unit tests it became clear to me that there are a lot of different edge cases and interdependencies of the code paths, so I think it's important to get this all straight first.

I will get back to this PR once we've decided on the other one. Thanks for your patience! 🙏

@svlandeg svlandeg changed the title Fix markdown formatting 🐛 Fix markdown formatting Sep 2, 2024
@lamehost
Copy link

Hello,

I am writing a Typer based application for which i need fairly elaborated command help messages. I am impacted by the problem described at #447 and i am looking for a solution. I don't mean to be pushy, but i am looking for the best thing to do and i wonder if i shall simply go through the monkey patch suggested on the issue or if i should wait for this to be merged. Is there any plan to incorporate the new code any time soon?

Thank you

Regards

@svlandeg
Copy link
Member

Hi @lamehost, apologies with the delay on this! We're currently finishing up #964 and then I'll get back to this one.

@svlandeg svlandeg self-assigned this Mar 20, 2025
@svlandeg svlandeg marked this pull request as ready for review April 10, 2025 15:38
@svlandeg
Copy link
Member

This PR should now be ready to merge. The unit tests were already merged into master with PR #964. The fix in this PR further allows us to remove an xfail from two of those tests. The markdown formatting of the help text should now be much better - fixing the issue #447.

@CJKay
Copy link

CJKay commented Jul 14, 2025

Can we expect this to release at any point in the near future? This bug currently renders some usage documentation totally unreadable (pun intended). 🙂

@svlandeg
Copy link
Member

Yes, we intend to merge & release this soonish, after Tiangolo has been able to give it a last check! (no need to ping him, he's aware).

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🚀 And thanks for the patience with this. ☕

Thanks @svlandeg for all the help! 🙌

This will be available in Typer 0.17.1 in the next few hours. 🎉

@tiangolo tiangolo changed the title 🐛 Fix markdown formatting 🐛 Fix markdown formatting in --help output Aug 30, 2025
@tiangolo tiangolo merged commit 4d1cfd2 into fastapi:master Aug 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential bug with new lines in the help output when markdown mode is used
5 participants