Skip to content

Ensure useEffectEvent implementation is available in Canary #34614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

Ensure useEffectEvent implementation is available in Canary #34614

merged 1 commit into from
Sep 26, 2025
+6 −6

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Sep 26, 2025 •
edited
Loading

Follow-up to #34610.
I forgot there's a separate feature flag not just the entrypoint like for <Activity>.

@eps1lon eps1lon requested a review from jackpope September 26, 2025 16:39
@meta-cla meta-cla bot added the CLA Signed label Sep 26, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 26, 2025
@react-sizebot
Copy link

react-sizebot commented Sep 26, 2025 •
edited
Loading

Comparing: 8bb7241...0fe2013

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.31% 534.43 kB 536.10 kB +0.48% 94.33 kB 94.79 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.69 kB 663.69 kB = 117.00 kB 117.00 kB
facebook-www/ReactDOM-prod.classic.js = 687.59 kB 687.59 kB = 121.04 kB 121.04 kB
facebook-www/ReactDOM-prod.modern.js = 678.02 kB 678.02 kB = 119.40 kB 119.39 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.61% 576.29 kB 579.82 kB +0.45% 92.87 kB 93.28 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.61% 576.32 kB 579.85 kB +0.45% 92.87 kB 93.29 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.61% 576.37 kB 579.90 kB +0.45% 92.89 kB 93.31 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js +0.58% 320.95 kB 322.81 kB +0.87% 55.81 kB 56.29 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js +0.58% 321.02 kB 322.89 kB +0.87% 55.83 kB 56.32 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js +0.58% 321.20 kB 323.06 kB +0.88% 55.87 kB 56.36 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.56% 580.77 kB 584.02 kB +0.41% 92.91 kB 93.29 kB
oss-stable/react-art/cjs/react-art.development.js +0.56% 580.84 kB 584.09 kB +0.41% 92.93 kB 93.32 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.54% 597.93 kB 601.15 kB +0.38% 96.62 kB 96.99 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.54% 597.93 kB 601.16 kB +0.38% 96.62 kB 96.99 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.53% 611.89 kB 615.11 kB +0.38% 98.10 kB 98.47 kB
react-native/implementations/ReactFabric-dev.js +0.50% 649.10 kB 652.36 kB +0.35% 105.25 kB 105.63 kB
oss-stable-semver/react-art/cjs/react-art.production.js +0.49% 308.82 kB 310.34 kB +0.82% 52.23 kB 52.66 kB
oss-stable/react-art/cjs/react-art.production.js +0.49% 308.90 kB 310.42 kB +0.82% 52.26 kB 52.69 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.49% 667.84 kB 671.09 kB +0.36% 108.17 kB 108.56 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.48% 342.40 kB 344.05 kB +0.83% 59.34 kB 59.84 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.48% 673.30 kB 676.52 kB +0.34% 106.56 kB 106.92 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.48% 673.32 kB 676.55 kB +0.34% 106.58 kB 106.95 kB
react-native/implementations/ReactFabric-prod.js +0.46% 359.15 kB 360.80 kB +0.71% 61.97 kB 62.41 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.45% 367.19 kB 368.84 kB +0.72% 62.74 kB 63.20 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.44% 374.69 kB 376.34 kB +0.70% 64.45 kB 64.91 kB
react-native/implementations/ReactFabric-prod.fb.js +0.43% 385.98 kB 387.63 kB +0.70% 66.74 kB 67.21 kB
react-native/implementations/ReactFabric-profiling.js +0.43% 387.15 kB 388.80 kB +0.70% 65.95 kB 66.40 kB
react-native/implementations/ReactFabric-dev.fb.js +0.43% 764.19 kB 767.44 kB +0.31% 121.41 kB 121.79 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.42% 772.87 kB 776.13 kB +0.33% 122.65 kB 123.05 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.42% 392.61 kB 394.26 kB +0.66% 67.70 kB 68.15 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.41% 402.66 kB 404.31 kB +0.66% 68.53 kB 68.98 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js +0.41% 405.80 kB 407.46 kB +0.73% 65.12 kB 65.60 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js +0.41% 405.83 kB 407.49 kB +0.73% 65.15 kB 65.62 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js +0.38% 435.06 kB 436.72 kB +0.63% 69.02 kB 69.46 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js +0.38% 435.09 kB 436.74 kB +0.63% 69.05 kB 69.49 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.36% 458.61 kB 460.26 kB +0.60% 76.61 kB 77.07 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.36% 465.16 kB 466.82 kB +0.59% 77.54 kB 78.00 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js +0.34% 986.11 kB 989.42 kB +0.22% 165.60 kB 165.96 kB
oss-stable/react-dom/cjs/react-dom-client.development.js +0.34% 986.23 kB 989.55 kB +0.22% 165.63 kB 165.99 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js +0.33% 1,002.49 kB 1,005.81 kB +0.21% 168.42 kB 168.78 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js +0.33% 1,002.61 kB 1,005.93 kB +0.22% 168.45 kB 168.81 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js +0.31% 534.31 kB 535.98 kB +0.48% 94.31 kB 94.76 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.31% 534.43 kB 536.10 kB +0.48% 94.33 kB 94.79 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js +0.29% 568.41 kB 570.08 kB +0.46% 99.35 kB 99.81 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js +0.29% 568.54 kB 570.21 kB +0.46% 99.38 kB 99.83 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js +0.29% 1,141.71 kB 1,145.02 kB +0.19% 188.58 kB 188.94 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js +0.29% 1,157.98 kB 1,161.29 kB +0.18% 191.39 kB 191.74 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js +0.28% 590.43 kB 592.10 kB +0.42% 103.89 kB 104.33 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js +0.28% 595.93 kB 597.60 kB +0.42% 104.96 kB 105.40 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js +0.25% 666.20 kB 667.87 kB +0.40% 114.05 kB 114.50 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js +0.25% 672.14 kB 673.81 kB +0.39% 115.21 kB 115.66 kB

Generated by 🚫 dangerJS against 0fe2013

@eps1lon eps1lon force-pushed the sebbie/09-26-ensure_useeffectevent_implementation_is_available_in_canary branch from 4fa4a81 to 0fe2013 Compare September 26, 2025 16:43
jackpope
jackpope approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@jackpope jackpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh. I forgot too. Thanks for the fix

@eps1lon eps1lon mentioned this pull request Sep 26, 2025
Closed
@eps1lon eps1lon merged commit df38ac9 into facebook:main Sep 26, 2025
241 checks passed
@eps1lon eps1lon deleted the sebbie/09-26-ensure_useeffectevent_implementation_is_available_in_canary branch September 26, 2025 16:53
github-actions bot pushed a commit that referenced this pull request Sep 26, 2025
@eps1lon
Ensure useEffectEvent implementation is available in Canary (#34614)
c4d4bc1 
DiffTrain build for [df38ac9](df38ac9)
github-actions bot pushed a commit that referenced this pull request Sep 26, 2025
@eps1lon
Ensure useEffectEvent implementation is available in Canary (#34614)
5a5734d 
DiffTrain build for [df38ac9](df38ac9)
@nextjs-bot nextjs-bot mentioned this pull request Sep 26, 2025
Merged
github-actions bot pushed a commit to code/lib-react that referenced this pull request Sep 27, 2025
@pull
Ensure useEffectEvent implementation is available in Canary (facebo…
5ba064c 
…ok#34614)

DiffTrain build for [df38ac9](facebook@df38ac9)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Sep 27, 2025
@pull
Ensure useEffectEvent implementation is available in Canary (facebo…
2452b9e 
…ok#34614)

DiffTrain build for [df38ac9](facebook@df38ac9)
EugeneChoi4 pushed a commit to EugeneChoi4/react that referenced this pull request Sep 29, 2025
@eps1lon @EugeneChoi4
Ensure useEffectEvent implementation is available in Canary (facebo…
71723e0 
…ok#34614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpope jackpope jackpope approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @react-sizebot @jackpope