[DevTools] Store Webpack stats when building extensions #34514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 16df13b...2042d7a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
sebbie/09-17-_devtools_store_webpack_stats_when_building_extensions
branch
2 times, most recently
from
bcbbf8a to
06d2c8b
Compare
hoxyq
approved these changes
Sep 17, 2025
The file is stored in `packages/react-devtools-extensions/build/webpack-stats*.json`. The filename includes feature flag target and browser. Creating the stats is cheap so we're always doing it for now. In CI, we'll persist the stats for download (`react-devtools`) artifact. The artifact used to contain a tarball but since we switched to GitHub Actions, we no longer do that considering GH Actions already creates a zip of the artifacts.
eps1lon
force-pushed
the
sebbie/09-17-_devtools_store_webpack_stats_when_building_extensions
branch
from
06d2c8b to
2042d7a
Compare
eps1lon
deleted the
sebbie/09-17-_devtools_store_webpack_stats_when_building_extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34507
The file is stored in
packages/react-devtools-extensions/build/webpack-stats*.json.The filename includes feature flag target and browser.
Creating the stats is cheap (after: 11.498 s ± 0.130 s, before: 10.903 s ± 0.209 s) so we're always doing it for now.
In CI, we'll persist the stats for download in GH artifacts (existing
react-devtoolsandreact-devtools-*-metadatainbuild-and-test).The artifact in the regression test job used to contain a tarball but since we switched to GitHub Actions,
we no longer need to do that considering GH Actions already creates a zip of the
artifacts.
The backend will get stats once we merge the Webpack configs.
Test plan
./scripts/ci/pack_and_store_devtools_artifacts.sh./scripts/ci/pack_and_store_devtools_artifacts.sh chrome