-
Notifications
You must be signed in to change notification settings - Fork 49.5k
Include component name in "async/await is not supported" error message if available #32435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+41
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c58ffc4
to
a338526
Compare
a338526
to
3adae2f
Compare
3adae2f
to
a840307
Compare
unstubbable
approved these changes
Feb 25, 2025
eps1lon
commented
Feb 25, 2025
throw new Error( | ||
'async/await is not yet supported in Client Components, only ' + | ||
'Server Components. This error is often caused by accidentally ' + | ||
'An unknown Component is an async Client Component. ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative would be "One of your Client Components is async". My concern for that wording is that it sounds like we do know which one but won't tell. "Unknown" makes it clearer that we just don't know. No strong opinion either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're using the same name we also use for deduping. Perfect Owner Stacks will be a bit trickier.
How did you test this change?
Updated tests.