Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 20, 2025

Summary

We're using the same name we also use for deduping. Perfect Owner Stacks will be a bit trickier.

How did you test this change?

Updated tests.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 20, 2025
@eps1lon eps1lon force-pushed the async-client-component-name branch from c58ffc4 to a338526 Compare February 20, 2025 17:19
@react-sizebot
Copy link

react-sizebot commented Feb 20, 2025

Comparing: 88479c6...70de9d3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.71 kB 515.71 kB = 92.09 kB 92.09 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 564.52 kB 562.25 kB = 100.55 kB 100.08 kB
facebook-www/ReactDOM-prod.classic.js = 636.70 kB 636.70 kB = 112.08 kB 112.08 kB
facebook-www/ReactDOM-prod.modern.js = 627.02 kB 627.02 kB = 110.50 kB 110.50 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-profiling.js +0.22% 383.86 kB 384.70 kB +0.17% 66.11 kB 66.22 kB
react-native/implementations/ReactFabric-prod.js +0.21% 358.62 kB 359.38 kB +0.18% 62.41 kB 62.52 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,055.58 kB 1,053.06 kB = 177.74 kB 177.23 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 1,055.06 kB 1,052.54 kB = 176.86 kB 176.34 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 1,038.67 kB 1,036.15 kB = 174.00 kB 173.49 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 485.96 kB 484.75 kB = 77.85 kB 77.59 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.95 kB 40.85 kB = 7.49 kB 7.47 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.95 kB 40.84 kB = 7.49 kB 7.46 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.92 kB 40.82 kB = 7.46 kB 7.43 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.81 kB 40.71 kB = 7.47 kB 7.45 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.81 kB 40.70 kB = 7.47 kB 7.45 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.78 kB 40.68 kB = 7.44 kB 7.42 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js = 36.74 kB 36.64 kB = 6.90 kB 6.88 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js = 36.74 kB 36.64 kB = 6.90 kB 6.87 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js = 36.71 kB 36.61 kB = 6.87 kB 6.84 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.js = 36.62 kB 36.51 kB = 6.88 kB 6.86 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.js = 36.61 kB 36.51 kB = 6.88 kB 6.86 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.js = 36.58 kB 36.48 kB = 6.85 kB 6.82 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 432.99 kB 431.79 kB = 69.98 kB 69.74 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 620.06 kB 617.80 kB = 109.25 kB 108.78 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 579.25 kB 576.98 kB = 104.13 kB 103.65 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 564.52 kB 562.25 kB = 100.55 kB 100.08 kB
react-native/shims/ReactNativeTypes.js = 8.73 kB 8.57 kB = 2.35 kB 2.28 kB

Generated by 🚫 dangerJS against a840307

throw new Error(
'async/await is not yet supported in Client Components, only ' +
'Server Components. This error is often caused by accidentally ' +
'An unknown Component is an async Client Component. ' +
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative would be "One of your Client Components is async". My concern for that wording is that it sounds like we do know which one but won't tell. "Unknown" makes it clearer that we just don't know. No strong opinion either way.

@eps1lon eps1lon merged commit 22e39ea into main Feb 25, 2025
194 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
@poteto poteto deleted the async-client-component-name branch March 11, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants