Skip to content

[DevTools] Refactor Forcing Fallback / Error of Suspense / Error Boundaries #30870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2024
Merged

[DevTools] Refactor Forcing Fallback / Error of Suspense / Error Boundaries #30870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c71acf
Move force error/fallback into Fiber Maps instead of Flags
sebmarkbage Sep 3, 2024
da1ad12
Compute targetErrorBoundaryID lazily when we actually try to set an e…
sebmarkbage Sep 4, 2024
1a49cac
Compute Suspense boundary to Force in the Backend
sebmarkbage Sep 4, 2024
66b5559
Support Suspending/Erroring Virtual Instances
sebmarkbage Sep 4, 2024
c7221da
Track if inside suspense or error boundary to highlight the buttons
sebmarkbage Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions packages/react-devtools-shared/src/__tests__/inspectedElement-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2975,16 +2975,12 @@ describe('InspectedElement', () => {
// Inspect <ErrorBoundary /> and see that we cannot toggle error state
// on error boundary itself
let inspectedElement = await inspect(0);
expect(inspectedElement.canToggleError).toBe(false);
expect(inspectedElement.targetErrorBoundaryID).toBe(null);
expect(inspectedElement.canToggleError).toBe(true);

// Inspect <Example />
inspectedElement = await inspect(1);
expect(inspectedElement.canToggleError).toBe(true);
expect(inspectedElement.isErrored).toBe(false);
expect(inspectedElement.targetErrorBoundaryID).toBe(
targetErrorBoundaryID,
);

// Suppress expected error and warning.
const consoleErrorMock = jest
Expand All @@ -3009,20 +3005,13 @@ describe('InspectedElement', () => {
inspectedElement = await inspect(0);
expect(inspectedElement.canToggleError).toBe(true);
expect(inspectedElement.isErrored).toBe(true);
// its error boundary ID is itself because it's caught the error
expect(inspectedElement.targetErrorBoundaryID).toBe(
targetErrorBoundaryID,
);

await toggleError(false);

// We can now inspect <Example /> with ability to toggle again
inspectedElement = await inspect(1);
expect(inspectedElement.canToggleError).toBe(true);
expect(inspectedElement.isErrored).toBe(false);
expect(inspectedElement.targetErrorBoundaryID).toBe(
targetErrorBoundaryID,
);
});
});

Expand Down
Loading
Loading