Allow faraday-multipart-1.1.0
#221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest ruby-3.0 compatible version, right now bundled-into-bundler thor is not compatible with ruby >= 3.1 due to [0] [0] rails/thor#761
Released in Dec 2024 [0]. Version constrain was more lax before 290d57e, but was needlessly tightened instead of setting the minimal accepted version. Relax it back. [0] https://github.com/lostisland/faraday-multipart/releases/tag/v1.1.0
|
…and sending to review due to `1 workflow awaiting approval`` |
|
@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Released in Dec 2024 [0].
Version constrain was more lax before 290d57e, but was needlessly tightened instead of setting the minimal accepted version.
Relax it back.
[0] https://github.com/lostisland/faraday-multipart/releases/tag/v1.1.0
And drive-by commit to update bundler version in
Gemfile.lockto fixbundlew/ latest rubies (see commit message), could extract to the separate PR if needed.Also GHA uses
bundler-1(which is not realistic since minimal supported ruby is3.0that ships w/bundler-2.2.3) and only rubies3.0&3.2, I'd like to create a PR to use all supported rubies w/obundlerversion override, but wanna have this PR merged first to work without annoyingFirst-time contributors need a maintainer to approve running workflows..