Fix with_session by migrating Session.new to keyword arguments

[larouxn]

I believe I have located a bug in the FacebookAds#with_session method in which it passes non-keyword arguments to Session.new on line 20. Bug being that Session instantiation only takes keyword arguments. If the method is in fact not broken, please do let me know, I could be overlooking something as I've just started working with this gem recently.

facebook-ruby-business-sdk/lib/facebook_ads.rb

Lines 18 to 23 in ef8dc9b

	def with_session(access_token, secret = nil, api_version = DEFAULT_API_VERSION)
	original_session = Session.current_session
	Session.current_session = Session.new(access_token, secret, api_version)
	yield
	Session.current_session = original_session
	end

facebook-ruby-business-sdk/lib/facebook_ads/session.rb

Lines 12 to 24 in ef8dc9b

	module FacebookAds
	class Session
	attr_accessor :access_token, :app_secret, :api_version, :server_host
	def initialize(access_token: nil,
	app_secret: nil,
	server_host: FacebookAds.config.server_host,
	api_version: FacebookAds.config.api_version)
	@access_token = access_token
	@app_secret = app_secret
	@server_host = server_host
	@api_version = api_version
	end

Here's a proof of concept of the current state versus the proposed changed state.

# current broken with_session
irb(main):004* FacebookAds.with_session(access_token, app_secret) do
irb(main):005*   FacebookAds::AdAccount.get(ad_account_id, "name")
irb(main):006> end
/home/spin/.bundle/shop-server/ruby-3.3.7/gems/facebookbusiness-21.0.2/lib/facebook_ads/session.rb:16:in `initialize': wrong number of arguments (given 3, expected 0) (ArgumentError)
        from /home/spin/.bundle/shop-server/ruby-3.3.7/gems/facebookbusiness-21.0.2/lib/facebook_ads.rb:20:in `new'
        from /home/spin/.bundle/shop-server/ruby-3.3.7/gems/facebookbusiness-21.0.2/lib/facebook_ads.rb:20:in `with_session'
        
# example fixed with_session minimal local method, irb line 32
irb(main):031* def with_session(access_token, app_secret = nil, api_version = "v21")
irb(main):032*   FacebookAds::Session.current_session = FacebookAds::Session.new(access_token:, app_secret:, api_version:)
irb(main):033*   yield
irb(main):034> end
=> :with_session
irb(main):035* with_session(access_token, app_secret) do
irb(main):036*   FacebookAds::AdAccount.get(ad_account_id, "name")
irb(main):037> end
=> #<FacebookAds::AdAccount {:id=>"act_redacted"}>
irb(main):038>

[facebook-github-bot]

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@stcheng merged this pull request in 2060570.