Skip to content

Specs are not passing #194

@dipth

Description

@dipth

Which SDK version are you using?

main

What's the issue?

Specs are failing with:

➜  facebook-ruby-business-sdk git:(main) ✗ bundle exec rspec
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.

An error occurred while loading ./spec/ad_object_spec.rb.
Failure/Error:
  RSpec.describe FacebookAds::AdObject do
  end

NameError:
  uninitialized constant FacebookAds::AdObject

  RSpec.describe FacebookAds::AdObject do
                            ^^^^^^^^^^
# ./spec/ad_object_spec.rb:19:in `<top (required)>'


Finished in 0.00004 seconds (files took 0.20585 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

Furthermore looking at .github/workflows/ci.yml it doesn't even appear that specs are run as part of the CI-build.

When was the last time someone actually ran these specs?

Steps/Sample code to reproduce the issue

git clone https://github.com/facebook/facebook-ruby-business-sdk.git
cd facebook-ruby-business-sdk
bundle install
bundle exec rspec

Observed Results:

Specs fail with the following error:

An error occurred while loading ./spec/ad_object_spec.rb.
Failure/Error:
  RSpec.describe FacebookAds::AdObject do
  end

NameError:
  uninitialized constant FacebookAds::AdObject

  RSpec.describe FacebookAds::AdObject do
                            ^^^^^^^^^^
# ./spec/ad_object_spec.rb:19:in `<top (required)>'

Expected Results:

Specs should have passed successfully.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions