Fixup specs and add RSpec run into CI

Minor ruby-3 kwarg issues, api changes and Symbol/String confusions
wrt Hash keys.

The single issue in the code is `FacebookAds::ServerSide::Event`,
where normalization is not performed when it should be.

Fixes 02c4351
Fixes 38f9a07
Fixes #194

Author: ojab

.github/workflows/ci.yml

@@ -18,5 +18,9 @@ jobs:
           ruby-version: ${{ matrix.version }}
           bundler-cache: true
 
+      - name: Run RSpec
+        continue-on-error: ${{ matrix.ruby == 'head' }}
+        run: bundle exec rspec
+
       - name: Gem build
         run: gem build *.gemspec

.rspec

@@ -0,0 +1 @@
+--require spec_helper

lib/facebook_ads/ad_objects/server_side/event.rb

@@ -411,10 +411,10 @@ def normalize
           hash['messaging_channel'] = messaging_channel
         end
         unless original_event_data.nil?
-          hash['original_event_data'] = original_event_data
+          hash['original_event_data'] = original_event_data.normalize
         end
         unless attribution_data.nil?
-          hash['attribution_data'] = attribution_data
+          hash['attribution_data'] = attribution_data.normalize
         end
         hash
       end

spec/lib/facebook_ads/ad_objects/server_side/attribution_data_spec.rb

@@ -39,14 +39,14 @@
         )
 
         expect(attribution_data.normalize).to eq({
-            'scope': scope,
-            'visit_time': visit_time,
-            'ad_id': ad_id,
-            'adset_id': adset_id,
-            'campaign_id': campaign_id,
-            'attr_window': attr_window,
-            'attribution_share': attribution_share,
-            'attribution_model': attribution_model,
+            'scope' => scope,
+            'visit_time' => visit_time,
+            'ad_id' => ad_id,
+            'adset_id' => adset_id,
+            'campaign_id' => campaign_id,
+            'attr_window' => attr_window,
+            'attribution_share' => attribution_share,
+            'attribution_model' => attribution_model,
         })
     end
 

spec/lib/facebook_ads/ad_objects/server_side/event_request_async_spec.rb

@@ -42,9 +42,9 @@
             messages: 'message3',
             fbtrace_id: 'fbtrace123',
         }
-        expected_response = FacebookAds::ServerSide::EventResponse.new(response)
+        expected_response = FacebookAds::ServerSide::EventResponse.new(**response)
         expect(mock_ads_pixel).to receive_message_chain('events.create').with(expected_params).and_return(response)
-        expect(FacebookAds::AdsPixel).to receive(:get).with(event_request_async.pixel_id).and_return(mock_ads_pixel)
+        expect(FacebookAds::AdsPixel).to receive(:get).with(event_request_async.pixel_id, nil).and_return(mock_ads_pixel)
         promise = event_request_async.execute
         response = promise.value!
 

spec/lib/facebook_ads/ad_objects/server_side/event_request_spec.rb

@@ -136,9 +136,9 @@
             messages: 'message3',
             fbtrace_id: 'fbtrace123',
         }
-        expected_response = FacebookAds::ServerSide::EventResponse.new(response)
+        expected_response = FacebookAds::ServerSide::EventResponse.new(**response)
         expect(mock_ads_pixel).to receive_message_chain('events.create').with(expected_params).and_return(response)
-        expect(FacebookAds::AdsPixel).to receive(:get).with(event_request.pixel_id).and_return(mock_ads_pixel)
+        expect(FacebookAds::AdsPixel).to receive(:get).with(event_request.pixel_id, nil).and_return(mock_ads_pixel)
         response = event_request.execute
 
         expect(response).to eq(expected_response)
@@ -159,9 +159,9 @@
             messages: 'message3',
             fbtrace_id: 'fbtrace123',
         }
-        expected_response = FacebookAds::ServerSide::EventResponse.new(response)
+        expected_response = FacebookAds::ServerSide::EventResponse.new(**response)
         expect(mock_ads_pixel).to receive_message_chain('events.create').with(expected_params).and_return(response)
-        expect(FacebookAds::AdsPixel).to receive(:get).with(event_request.pixel_id).and_return(mock_ads_pixel)
+        expect(FacebookAds::AdsPixel).to receive(:get).with(event_request.pixel_id, nil).and_return(mock_ads_pixel)
         response = event_request.execute
 
         expect(response).to eq(expected_response)

spec/lib/facebook_ads/ad_objects/server_side/user_data_spec.rb

@@ -41,7 +41,7 @@
         allow(FacebookAds::ServerSide::Util).to receive(:normalize) do |input, field_type|
             "#{field_type}_#{input}-normalized"
         end
-        user_data = FacebookAds::ServerSide::UserData.new(attrs)
+        user_data = FacebookAds::ServerSide::UserData.new(**attrs)
         normalized = user_data.normalize
 
         expect(normalized).to eq(
@@ -83,7 +83,7 @@
         allow(FacebookAds::ServerSide::Util).to receive(:normalize_array) do |input, field_type|
             input + [field_type]
         end
-        user_data = FacebookAds::ServerSide::UserData.new(attrs)
+        user_data = FacebookAds::ServerSide::UserData.new(**attrs)
         normalized = user_data.normalize
 
         expect(normalized).to eq(
@@ -216,8 +216,8 @@
         expect(user_data1).to eq(user_data2)
         expect(user_data1.hash).to eq(user_data2.hash)
 
-        user_data1 = FacebookAds::ServerSide::UserData.new(attrs)
-        user_data2 = FacebookAds::ServerSide::UserData.new(attrs)
+        user_data1 = FacebookAds::ServerSide::UserData.new(**attrs)
+        user_data2 = FacebookAds::ServerSide::UserData.new(**attrs)
         expect(user_data1).to eq(user_data2)
         expect(user_data1.hash).to eq(user_data2.hash)
     end