Skip to content

Conversation

dmitry-timofeev
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev commented Jun 21, 2019

Overview

Always clean the lib/java target before copying Java artifacts.

Also clean the whole Cargo target directory before packaging,
as it will recompile things anyway. Cleaning can be skipped,
if desired, with the --skip-cargo-clean flag.


See: https://jira.bf.local/browse/ECR-3286

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

Also clean the whole Cargo target directory before packaging,
as it will recompile things anyway. Cleaning can be skipped,
if desired, with the `--skip-cargo-clean` flag.
@dmitry-timofeev dmitry-timofeev changed the title Always clean the lib/java target before copying artifacts: [ECR-3286] Clean the lib/java target before copying artifacts: [ECR-3286] Jun 21, 2019
request. It is modified to return an empty object by default (no info in `content.debug` field
of the response to `transaction`). (#904)
- Application packaging issue that might have resulted in several versions of Java artifacts
on the application classpath.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR link is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unknown when one writes the changelog.

@coveralls
Copy link

coveralls commented Jun 21, 2019

Coverage Status

Coverage remained the same at 85.398% when pulling 17a7691 on dmitry-timofeev:fix-packaging-ECR-3286 into 0b344d5 on exonum:master.

@dmitry-timofeev dmitry-timofeev merged commit 6096a0b into exonum:master Jun 24, 2019
@dmitry-timofeev dmitry-timofeev deleted the fix-packaging-ECR-3286 branch June 24, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants