[ECR-2746] Transaction Preconditions #1351
Conversation
| * check(amount <= balance, (byte)3, | ||
| * "Not enough money. Operation amount is %s, but actual balance was %s", | ||
| * amount, balance); | ||
| * }</pre> |
There was a problem hiding this comment.
+ a back link from ExecutionException.
* @see ExecutionException
| * amount, balance); | ||
| * }</pre> | ||
| */ | ||
| public final class Preconditions { |
There was a problem hiding this comment.
ExecutionPreconditions (as they are tied to ExecException)? That will allow
to use both Guava's and ours as simple names.
Also, I'd ponder on the name of 'check' methods. 'check' seems too vague. Shall
we use 'checkExecution' (because Execution Exception, also, it is similar to Guava's naming 'checkArgument' -> Illegal Argument Exception)? Do you have any other names in mind?
| * | ||
| * <p>See {@link #check(boolean, byte, String, Object...)} for details. | ||
| */ | ||
| public static void check(boolean expression, byte errorCode, |
There was a problem hiding this comment.
How the set of overloads was choosen?
There was a problem hiding this comment.
A fascinating talk on how they do it at Google, helping design not only APIs but languages: https://www.youtube.com/watch?v=sPW2Pz2dI9E&list=LLXsc0bWTsranC6H8z1IOoXg&index=10&t=0s (@vitvakatu , @slowli )
That's what we often miss — data on the actual usages to make informed decisions, instead of speculations 🙃
There was a problem hiding this comment.
just tried to cover most frequently used cases + inspired by guava lib 🙃
| * @param expression a boolean expression | ||
| * @param errorCode execution error code | ||
| * @param errorMessageTemplate execution error description template to use if the check fails. | ||
| * The template could have placeholders {@code %s} which will be replaces by arguments |
exonum-java-binding/CHANGELOG.md
Outdated
| `ProofListIndexProxy.getProof`, `ProofListIndexProxy.getRangeProof` and | ||
| `ListProof`. | ||
| - `ProofEntryIndexProxy` collection. | ||
| - Transaction precondition utility methods. |
There was a problem hiding this comment.
Specify class name?
| MapIndex<PublicKey, Wallet> wallets = schema.wallets(); | ||
|
|
||
| checkExecution(!wallets.containsKey(ownerPublicKey), WALLET_ALREADY_EXISTS.errorCode); | ||
| ExecutionPreconditions |
There was a problem hiding this comment.
Shan't we use static imports for it?
Overview
See: https://jira.bf.local/browse/ECR-2746
Definition of Done