Skip to content

[ECR-4021] Reflect proto changes for Block #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

[ECR-4021] Reflect proto changes for Block #1350

merged 1 commit into from
Jan 9, 2020

Conversation

bullet-tooth
Copy link
Contributor

Overview

See: https://jira.bf.local/browse/ECR-4021

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@bullet-tooth
Copy link
Contributor Author

Re-created from #1330

@bullet-tooth bullet-tooth merged commit 893884d into new-protos-base Jan 9, 2020
@bullet-tooth bullet-tooth deleted the ecr-4021-new branch January 9, 2020 08:30
vitvakatu pushed a commit that referenced this pull request Jan 9, 2020
@bullet-tooth
[ECR-4021] reflect proto changes for Block (#1350)
2cc97c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dmitry-timofeev dmitry-timofeev dmitry-timofeev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bullet-tooth @dmitry-timofeev