Skip to content

Make protobuf dependency in common transitive #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

Make protobuf dependency in common transitive #1246

merged 1 commit into from
Nov 28, 2019

Conversation

MakarovS
Copy link
Contributor

@MakarovS MakarovS commented Nov 27, 2019 •
edited
Loading

Overview

Make protobuf dependency in common transitional. See #1244 (comment)

Definition of Done

  • There are no TODOs left in the code
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.884% when pulling c90e922 on fix-protobuf-dependency-ejb-common into abb3a13 on master.

@MakarovS MakarovS mentioned this pull request Nov 28, 2019
Merged
7 tasks
@MakarovS MakarovS changed the title Make protobuf dependency in common transitional Make protobuf dependency in common transitive Nov 28, 2019
@dmitry-timofeev dmitry-timofeev merged commit d613433 into master Nov 28, 2019
@dmitry-timofeev dmitry-timofeev deleted the fix-protobuf-dependency-ejb-common branch November 28, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dmitry-timofeev dmitry-timofeev dmitry-timofeev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MakarovS @coveralls @dmitry-timofeev