Make QA service configurable [ECR-3869] #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-timofeev
added
the
work-in-progress 👷♂️
dmitry-timofeev
force-pushed
the
make-qa-service-configurable-again-ECR-3869
branch
from
5035f0e to
9425dfe
Compare
dmitry-timofeev
changed the title
- It requires an active supervisor in testkit: ECR-3873 - It requires the supervisor proto-definitions (which are not currently included in exonum-proto-sources)
dmitry-timofeev
force-pushed
the
make-qa-service-configurable-again-ECR-3869
branch
from
9425dfe to
28e1862
Compare
dmitry-timofeev
removed
the
work-in-progress 👷♂️
MakarovS
approved these changes
Dec 2, 2019
| updateTimeOracle(fork, configuration); | ||
| } | ||
|
|
||
| private void checkConfiguration(InitialConfiguration config) { |
There was a problem hiding this comment.
Shouldn't we rename InitialConfiguration if it's not necessarily initial?
There was a problem hiding this comment.
Good observation, thanks, let it be QaConfiguration.
(@ivan-ochc — see the patches to the specification: https://wiki.bf.local/pages/viewpreviousversions.action?pageId=1710016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The tests are not added, as they require some dependencies (and it isn't definitev if it make sense to create supervisor transactions here). The original test remains available in
015d820.
See: https://jira.bf.local/browse/ECR-3869
Definition of Done