Skip to content

Conversation

dmitry-timofeev
Copy link
Contributor

Overview

Provide access to consensus configuration instead of all configuration
according with the changes in core.

Remove the Java types representing the consensus configuration
in favour of the generated protobuf messages.


See: https://jira.bf.local/browse/ECR-3612

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

Provide access to consensus configuration instead of all configuration
according with the changes in core.

Remove the Java types representing the consensus configuration
in favour of the generated protobuf messages.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.819% when pulling e4dca44 on dmitry-timofeev:add-consensus-config-ECR-3612 into 655eb58 on exonum:dynamic-services.

@MakarovS MakarovS mentioned this pull request Oct 25, 2019
7 tasks
Copy link
Contributor

@MakarovS MakarovS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmitry-timofeev dmitry-timofeev merged commit 5561f17 into exonum:dynamic-services Oct 28, 2019
@dmitry-timofeev dmitry-timofeev deleted the add-consensus-config-ECR-3612 branch October 28, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants