Update ServiceRuntime proxy in Rust to the current Exonum revision [ECR-3698] #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
added
the
work-in-progress 👷♂️
vitvakatu
force-pushed
the
ecr-3698-update-to-latest-revision
branch
from
8e02151 to
da2320c
Compare
vitvakatu
changed the base branch from
dynamic-services
to
dynamic-services-upgraded-ECR-3664
vitvakatu
changed the title
vitvakatu
removed
the
work-in-progress 👷♂️
vitvakatu
commented
Oct 24, 2019
| protobuf_generate("../src/main/proto", &["src/proto"], "protobuf_mod.rs"); | ||
| ProtobufGenerator::with_mod_name("protobuf_mod.rs") | ||
| .with_input_dir("../src/main/proto") | ||
| .add_path("../src/main/proto") |
There was a problem hiding this comment.
Do not even ask me about what is going on here and why we need two identical arguments for different methods.
7 tasks
dmitry-timofeev
approved these changes
Oct 24, 2019
|
|
||
| fn shutdown(&self) { | ||
| unwrap_jni(self.exec.with_attached(|env| { | ||
| panic_on_exception( |
There was a problem hiding this comment.
Does the core have a panic-resilient implementation?
There was a problem hiding this comment.
Nope :) Created ECR-3725
skletsun
reviewed
Oct 24, 2019
skletsun
reviewed
Oct 24, 2019
skletsun
approved these changes
Oct 24, 2019
dmitry-timofeev
pushed a commit
that referenced
this pull request
Oct 24, 2019
…CR-3698] (#1179) Update Java Runtime to newer revision of Core: exonum/exonum@47114e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updated to revision 47114e3 as no functional changes were made since 0f44d1c
See: https://jira.bf.local/browse/ECR-3698
Definition of Done