Skip to content

Add #stream to sets: #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 4, 2019
Merged

Add #stream to sets: #1088

merged 5 commits into from
Sep 4, 2019

Conversation

dmitry-timofeev
Copy link
Contributor

A simple non-splittable implementation is OK for the sets are not
currently sized.

Overview

See: https://jira.bf.local/browse/ECR-XYZ

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@dmitry-timofeev
Add #stream to sets:
a240f0a 
A simple non-splittable implementation is OK for the sets are not
currently sized.
@dmitry-timofeev
Fix checkstyle
5218111
@coveralls
Copy link

coveralls commented Aug 28, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 85.95% when pulling 4c9a46f on dmitry-timofeev:add-stream-to-sets into e64c544 on exonum:master.

@vitvakatu vitvakatu requested a review from MakarovS September 3, 2019 08:33
@vitvakatu vitvakatu merged commit 3ab3a6b into exonum:master Sep 4, 2019
@dmitry-timofeev dmitry-timofeev deleted the add-stream-to-sets branch December 12, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@bullet-tooth bullet-tooth bullet-tooth approved these changes

@MakarovS MakarovS MakarovS approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmitry-timofeev @coveralls @bullet-tooth @MakarovS @vitvakatu