-
Notifications
You must be signed in to change notification settings - Fork 177
β¨ feat(tests): EIP-7928 Single-Opcode Success and OOG test cases #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_oog.py
Outdated
Show resolved
Hide resolved
tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_oog.py
Outdated
Show resolved
Hide resolved
780a23e
to
c89d947
Compare
c89d947
to
4f79419
Compare
@raxhvl, as you know, we're pushing toward The Weldβ’ at the moment (eels + eest merging) and so we are trying to get PRs close to mergeable. I'm happy to go a different direction here but this needed a rebase, lint fixing, and all the tests needed the expectations updated so I made some decisions and pushed them that we can then work on top of. Let's discuss the approach here if this is not what we want but my changes here, other than rebasing and lint fix, were:
I think this makes the cases more obvious to a reader (subtracting exactly |
4f79419
to
4453022
Compare
Thanks @fselmo, I agree with all your decisions. I think between this and the positive we cover a lot of ground. @marioevz does it cover everything you had in mind? There are some more OOG test cases in this PR: #2116, lets add them later and keep this PR minimal. I made a small change - added ids to test parameters to make results more readable. 6d0de55 |
4453022
to
e8b5ca4
Compare
tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_opcodes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ππΌ Thanks!
ποΈ Description
π Related Issues or PRs
N/A.
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.