fix(src): besu cli issue resolved #2099
Open
+27
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
On ARM systems besu's evmtool might print the warning
Unable to get SVE vector length on this system. Disabling SVE. Specify -XX:UseSVE=0 to shun this warning
before the version when runningevmtool --version
. This PR improves the logic inethereum_cli.py
to handle this case. This PR contains a second fix, besu now shows its version as e.g.Hyperledger Besu evm 25.2.0
so the regex had to adjusted to allow words before the Besu part of the string.Other t8n's behavior is unaffected by this PR (e.g. eels and geth's evm still work).
That being said, I'm unsure how useful besu t8n is for us currently. Commands like
uv run fill --clean --evm-bin=$HOME/Documents/besu/besu-25.2.0/bin/evmtool tests/constantinople/eip1014_create2/test_recreate.py --eest-log-level=DEBUG -vv -s
fail with it when they successfully fill with geth or eels. Maybe it has been broken ever since the spec-evm-resolver was introduced? Context #818🔗 Related Issues or PRs
N/A.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.