-
Notifications
You must be signed in to change notification settings - Fork 185
Update P4 config for C5 slaves #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently used 2.0.12 ESP-HOSTED version is not up to date It could make sense to update this component first onto a more recent stable release, |
@lyusupov the latest esp-hosted will be used when libs are built. If you get the ones from this PR, they will/should be the latest version |
Uhmmm... some bad news: espressif/esp-hosted-mcu#71 (comment) |
@me-no-dev I think the currently most used (and configured) slave MCU is the C6. So the currently merged PR #323 can be kept. All other slave setups have to use Arduino as an component of IDF and adopting the sdkconfig settings. |
I see no arguments to apply a breaking #323 PR with an imaginary "performance improvement" at cost of reducing compatibility with other products made by honorable Espressiif company. I believe that : Espressiif products compatibility - first, performance -second. @me-no-dev I've placed my comment in espressif/esp-hosted-mcu#71 (comment) thread. |
@me-no-dev So I have no objections for you to apply this PR #324 |
@lyusupov given that currently custom libs are required for C5 to be used as slave, I suggest we keep this open but not merged for the time being. You can adjust the values in your lib-builder manually, since you are using it anyway. |
No, that's not true. I am not sure that you know or not - but the https://github.com/espressif/esp32-arduino-lib-builder since many months ago is failing to build the artifacts when a regular GitHub user makes a fork of the repo and executes the Actions script manually by pushing a commit. It looks like there are certain permission restrictions on certain resources in use during the build. ![]() That's why to garb some binaries from master repo https://github.com/espressif/esp32-arduino-lib-builder/actions Actions build is the only way to take the updated libs created by someone else. |
@lyusupov I meant locally on your computer. |
No. I have neither enough resources nor knowledge on how to do that. |
This pull request updates several Wi-Fi RMT buffer and window configuration parameters in the
configs/defconfig.esp32p4
file. The changes primarily reduce buffer sizes and the receive window, likely to optimize memory usage or improve performance for the ESP32-P4 platform.Wi-Fi RMT buffer and window configuration adjustments:
CONFIG_WIFI_RMT_STATIC_RX_BUFFER_NUM
from 16 to 10, decreasing the number of static receive buffers allocated for Wi-Fi RMT operations.CONFIG_WIFI_RMT_DYNAMIC_RX_BUFFER_NUM
from 64 to 32 andCONFIG_WIFI_RMT_DYNAMIC_TX_BUFFER_NUM
from 64 to 32, lowering the dynamic buffer allocation for both RX and TX.CONFIG_WIFI_RMT_RX_BA_WIN
from 32 to 16, decreasing the block acknowledgment receive window size.Reference: #323