Fixes ESP32-S2 LEDC PWM #5375 #5050 #5452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
reviewed
Jul 26, 2021
| uint8_t group=(chan/8), timer=((chan/2)%4); | ||
| static bool tHasStarted = false; | ||
| static uint16_t _activeChannels = 0; | ||
| #if CONFIG_IDF_TARGET_ESP32S2 |
There was a problem hiding this comment.
is this true just for S2 or also for C3 (S3 maybe?)
There was a problem hiding this comment.
I tested it on C3 as well. It works fine on it given that C3 has not such bit, thus there is no issue/fix to be done.
There was a problem hiding this comment.
S3 not tested, but it shall work as it follows the same register/bit set of C3 regarding CLK SELECTION for LEDC Timer/Counter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5375
Fixes: #5050