Skip to content

fix: silence multiple warnings pointed in issue #11917 #11920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2025
Merged

fix: silence multiple warnings pointed in issue #11917 #11920

merged 5 commits into from
Oct 17, 2025
+33 −15

Conversation

cziter15
Copy link
Contributor

@cziter15 cziter15 commented Oct 14, 2025 •
edited
Loading

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

Resolve warnings as described in #11917

Related links

Closes #11917

@cziter15 cziter15 requested review from a team and me-no-dev as code owners October 14, 2025 07:36
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Remove deprecated flush() comment in WebServer.cpp":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello cziter15, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4b39d79

@cziter15 cziter15 changed the title fix: silence warnings pointed in issue #11917, minor performance fixes fix: silence multiple warnings pointed in issue #11917 Oct 14, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2025
View reviewed changes
@cziter15
Remove deprecated flush() comment in WebServer.cpp
85cfbbe 
Removed deprecated flush() comment and updated code.
@cziter15
Copy link
Contributor Author

cziter15 commented Oct 14, 2025 •
edited
Loading

@me-no-dev Not sure about that bus_pointer check in ETH. Am I correct here?
PS. Is it mandatory to follow conventional commits inside a PR (not only PR title?) ?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025 •
edited
Loading

Test Results

 76 files   76 suites   16m 7s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 4b39d79.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5💚 -20⚠️ +60.000.00000.000.00
ESP32P4💚 -20⚠️ +60.000.00000.000.00
ESP32S30⚠️ +160.000.00000.000.00
ESP32S20⚠️ +200.000.00000.000.00
ESP32C3💚 -20⚠️ +60.000.00000.000.00
ESP32C6💚 -20⚠️ +60.000.00000.000.00
ESP32H20⚠️ +60.000.00000.000.00
ESP320⚠️ +40.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA000000000000--00
libraries/AsyncUDP/examples/AsyncUDPClient000000000000--00
libraries/AsyncUDP/examples/AsyncUDPMulticastServer000000000000--00
libraries/AsyncUDP/examples/AsyncUDPServer000000000000--00
libraries/DNSServer/examples/CaptivePortal000000000000--00
libraries/ESP32/examples/Time/SimpleTime000000000000--00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Network00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Serial00--00000000--00
libraries/ESPmDNS/examples/mDNS-SD_Extended000000000000--00
libraries/ESPmDNS/examples/mDNS_Web_Server000000000000--00
libraries/Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +60⚠️ +60⚠️ +40⚠️ +40⚠️ +60⚠️ +60⚠️ +60⚠️ +40
libraries/Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +60⚠️ +60⚠️ +40⚠️ +40⚠️ +60⚠️ +60⚠️ +60⚠️ +40
libraries/Ethernet/examples/ETH_WIFI_BRIDGE⚠️ +60⚠️ +60⚠️ +40⚠️ +40⚠️ +60⚠️ +60--⚠️ +40
libraries/FFat/examples/FFat_time000000000000--00
libraries/HTTPClient/examples/Authorization💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/HTTPClient/examples/BasicHttpClient💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/HTTPClient/examples/BasicHttpsClient💚 -200💚 -200⚠️ +120⚠️ +200💚 -200💚 -200--00
libraries/HTTPClient/examples/CustomHeaders💚 -200💚 -200⚠️ +120⚠️ +160💚 -200💚 -200--00
libraries/HTTPClient/examples/HTTPClientEnterprise💚 -200--⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/HTTPClient/examples/ReuseConnection💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/HTTPClient/examples/StreamHttpClient💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/HTTPUpdate/examples/httpUpdate000000000000--00
libraries/HTTPUpdate/examples/httpUpdateSPIFFS000000000000--00
libraries/HTTPUpdate/examples/httpUpdateSecure💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/HTTPUpdateServer/examples/WebUpdater000000000000--00
libraries/Hash/examples/PBKDF2_HMAC0000000000000000
libraries/Insights/examples/DiagnosticsSmokeTest00--00000000--00
libraries/Insights/examples/MinimalDiagnostics00--00000000--00
libraries/LittleFS/examples/LITTLEFS_test0000000000000000
libraries/LittleFS/examples/LITTLEFS_time000000000000--00
libraries/Matter/examples/MatterColorLight00--000000000000
libraries/Matter/examples/MatterCommissionTest00--000000000000
libraries/Matter/examples/MatterComposedLights00--000000000000
libraries/Matter/examples/MatterContactSensor00--000000000000
libraries/Matter/examples/MatterDimmableLight00--000000000000
libraries/Matter/examples/MatterEnhancedColorLight00--000000000000
libraries/Matter/examples/MatterEvents00--000000000000
libraries/Matter/examples/MatterFan00--000000000000
libraries/Matter/examples/MatterHumiditySensor00--000000000000
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs00--000000000000
libraries/Matter/examples/MatterMinimum00--000000000000
libraries/Matter/examples/MatterOccupancySensor00--000000000000
libraries/Matter/examples/MatterOnIdentify00--000000000000
libraries/Matter/examples/MatterOnOffLight00--000000000000
libraries/Matter/examples/MatterOnOffPlugin00--000000000000
libraries/Matter/examples/MatterPressureSensor00--000000000000
libraries/Matter/examples/MatterSmartButon00--000000000000
libraries/Matter/examples/MatterTemperatureLight00--000000000000
libraries/Matter/examples/MatterTemperatureSensor00--000000000000
libraries/Matter/examples/MatterThermostat00--000000000000
libraries/NetBIOS/examples/ESP_NBNST000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientInsecure💚 -200💚 -200⚠️ +160⚠️ +120💚 -200💚 -200--00
libraries/NetworkClientSecure/examples/WiFiClientPSK💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/NetworkClientSecure/examples/WiFiClientSecure💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise💚 -200--⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/NetworkClientSecure/examples/WiFiClientShowPeerCredentials💚 -200💚 -200⚠️ +120⚠️ +160💚 -200💚 -200--00
libraries/NetworkClientSecure/examples/WiFiClientTrustOnFirstUse💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/PPP/examples/PPP_Basic0000000000000000
libraries/PPP/examples/PPP_WIFI_BRIDGE000000000000--00
libraries/RainMaker/examples/RMakerCustom00--00000000----
libraries/RainMaker/examples/RMakerCustomAirCooler00--00000000----
libraries/RainMaker/examples/RMakerSonoffDualR300--00000000----
libraries/RainMaker/examples/RMakerSwitch00--00000000----
libraries/SD/examples/SD_time000000000000--00
libraries/SPIFFS/examples/SPIFFS_time000000000000--00
libraries/Update/examples/AWS_S3_OTA_Update000000000000--00
libraries/Update/examples/HTTPS_OTA_Update000000000000--00
libraries/Update/examples/HTTP_Client_AES_OTA_Update000000000000--00
libraries/Update/examples/HTTP_Server_AES_OTA_Update000000000000--00
libraries/Update/examples/OTAWebUpdater000000000000--00
libraries/Update/examples/SD_Update0000000000000000
libraries/WebServer/examples/AdvancedWebServer000000000000--00
libraries/WebServer/examples/ChunkWriting000000000000--00
libraries/WebServer/examples/FSBrowser000000000000--00
libraries/WebServer/examples/Filters000000000000--00
libraries/WebServer/examples/HelloServer000000000000--00
libraries/WebServer/examples/HttpAdvancedAuth000000000000--00
libraries/WebServer/examples/HttpAuthCallback000000000000--00
libraries/WebServer/examples/HttpAuthCallbackInline000000000000--00
libraries/WebServer/examples/HttpBasicAuth000000000000--00
libraries/WebServer/examples/HttpBasicAuthSHA1000000000000--00
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken000000000000--00
libraries/WebServer/examples/Middleware00--00000000--00
libraries/WebServer/examples/MultiHomedServers000000000000--00
libraries/WebServer/examples/PathArgServer000000000000--00
libraries/WebServer/examples/SDWebServer000000000000--00
libraries/WebServer/examples/SimpleAuthentification000000000000--00
libraries/WebServer/examples/UploadHugeFile000000000000--00
libraries/WebServer/examples/WebServer000000000000--00
libraries/WebServer/examples/WebUpdate000000000000--00
libraries/WiFi/examples/FTM/FTM_Initiator000000000000--00
libraries/WiFi/examples/FTM/FTM_Responder000000000000--00
libraries/WiFi/examples/SimpleWiFiServer000000000000--00
libraries/WiFi/examples/WPS00--00000000--00
libraries/WiFi/examples/WiFiAccessPoint000000000000--00
libraries/WiFi/examples/WiFiBlueToothSwitch00--00--0000--00
libraries/WiFi/examples/WiFiClient000000000000--00
libraries/WiFi/examples/WiFiClientBasic000000000000--00
libraries/WiFi/examples/WiFiClientConnect000000000000--00
libraries/WiFi/examples/WiFiClientEnterprise00--00000000--00
libraries/WiFi/examples/WiFiClientEvents000000000000--00
libraries/WiFi/examples/WiFiClientStaticIP000000000000--00
libraries/WiFi/examples/WiFiExtender000000000000--00
libraries/WiFi/examples/WiFiIPv6000000000000--00
libraries/WiFi/examples/WiFiMulti000000000000--00
libraries/WiFi/examples/WiFiMultiAdvanced💚 -200💚 -200⚠️ +120⚠️ +120💚 -200💚 -200--00
libraries/WiFi/examples/WiFiScan000000000000--00
libraries/WiFi/examples/WiFiScanAsync000000000000--00
libraries/WiFi/examples/WiFiScanDualAntenna000000000000--00
libraries/WiFi/examples/WiFiScanTime000000000000--00
libraries/WiFi/examples/WiFiSmartConfig00--00000000--00
libraries/WiFi/examples/WiFiTelnetToSerial000000000000--00
libraries/WiFi/examples/WiFiUDPClient000000000000--00
libraries/WiFiProv/examples/WiFiProv00--00000000--00
libraries/Zigbee/examples/Zigbee_Gateway00--000000----00
libraries/Ethernet/examples/ETH_TLK110--⚠️ +60----------⚠️ +40
libraries/SD_MMC/examples/SDMMC_time--0000--------00
libraries/ESP32/examples/Camera/CameraWebServer----0000------00
ESP32/examples/Camera/CameraWebServer (2)----0000------00
ESP32/examples/Camera/CameraWebServer (3)----00----------
libraries/Ethernet/examples/ETH_LAN8720--------------⚠️ +40

Jason2866
Jason2866 reviewed Oct 14, 2025
View reviewed changes
@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Oct 17, 2025
@me-no-dev
Copy link
Member

@lucasssvaz PTAL

@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Oct 17, 2025
@me-no-dev me-no-dev merged commit 298e40c into espressif:master Oct 17, 2025
54 checks passed
@cziter15 cziter15 deleted the fix-issue-11917 branch October 17, 2025 18:21
@cziter15
Copy link
Contributor Author

Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

+1 more reviewer

@Jason2866 Jason2866 Jason2866 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Various Compiler Warnings in ESP32 Framework after enabling warning flags

5 participants

@cziter15 @CLAassistant @me-no-dev @Jason2866 @lucasssvaz