Skip to content

fix: correctly handle version ranges in prefer-node-protocol #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

fix: correctly handle version ranges in prefer-node-protocol #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dff8ca
test: Add failing test for #453
scagood Jul 3, 2025
0aa5cbe
fix: correctly handle version ranges in prefer-node-protocol
scagood Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/rules/prefer-node-protocol.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const {
getPropertyName,
} = require("@eslint-community/eslint-utils")

const { Range } = require("semver")
const { subset, Range } = require("semver")

const getConfiguredNodeVersion = require("../util/get-configured-node-version")
const stripImportPathParams = require("../util/strip-import-path-params")
Expand Down Expand Up @@ -57,15 +57,12 @@ function isEnablingThisRule(context, moduleStyle) {
const version = getConfiguredNodeVersion(context)

// Only check Node.js version because this rule is meaningless if configured Node.js version doesn't match semver range.
if (!version.intersects(supportedRangeForEsm)) {
if (!subset(version, supportedRangeForEsm)) {
return false
}

// Only check when using `require`
if (
moduleStyle === "require" &&
!version.intersects(supportedRangeForCjs)
) {
if (moduleStyle === "require" && !subset(version, supportedRangeForCjs)) {
return false
}

Expand Down
4 changes: 4 additions & 0 deletions tests/lib/rules/prefer-node-protocol.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ new RuleTester({
'const fs = require("eslint-plugin-n");',

// check disabling by supported Node.js versions
{
options: [{ version: ">=10.13.0" }],
code: 'import fs from "fs";',
},
{
options: [{ version: "12.19.1" }],
code: 'import fs from "fs";',
Expand Down