Skip to content

Conversation

carltongibson
Copy link
Collaborator

@carltongibson carltongibson commented Apr 10, 2020

DRAFT I'll finish it over the next few days couple of months. (My word: not had a moment since this pandemic struck here in earnest.) 🗿

OK, done now. Explains the approach and covers the most important methods. Maybe we can add some of the lesser ones over time, but TBH folks'll see that when they're using the main ones, so it's not urgent for this pass, especially given lack of bandwidth now.

@carltongibson
Copy link
Collaborator Author

Quick update: Added guidance on subclassing AutoSchema. Just need to doc the now public AutoSchema methods and it's more or less there.

@carltongibson carltongibson marked this pull request as ready for review June 9, 2020 18:29
Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic stuff.

There's a couple of minor merge conflicts at the moment - I'll let you resolve those, then I'm happy if you are.

@carltongibson
Copy link
Collaborator Author

OK, rebased, squashed and a few tweaks caught on a read-over.

@carltongibson carltongibson merged commit e18e40d into encode:master Jun 16, 2020
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants