Add schema to the ObtainAuthToken view #5676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add encoding parameter to ManualSchema
scardine
force-pushed
the
scardine-patch-1
branch
from
e070344 to
ef33753
Compare
|
Hi @scardine. There's two things going on here: adding the ManualFields schema to the ObtainAuthToken view, and adding the encoding parameter to ManualFields. We should handle these separately. Adding the fields to the ObtainAuthToken view seems reasonable. Can you make a different PR handling the encoding please? (Docs and tests there would be needed.) Also we have a lint failure |
|
Fair enough, I will cleanup and submit again. |
|
Hi @scardine. I fixed the lint error and added the docs for the new |
6 tasks
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
Add encoding parameter to ManualSchema Closes encode#5676 * Fixed lint errors * Added docs for ManualSchema encoding parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
usernameandpasswordfields were not described in the document created byinclude_docs_urls. This fixes it for me, don't know if there is a better way to do it.