Codecov is not tracking all DRF modules

[rpkilby]

I was just noticing that there was no report for #5646. This appears to be caused by the PR's commits not altering any files tracked by codecov. Looking into the tracked files, it turns out that a few modules are missing, including serializers.py and views.py.

https://codecov.io/gh/encode/django-rest-framework/pull/5646/tree/rest_framework

[carltongibson]

@treyhunner Are you still with Codecov? Any chance you could have a look at our config here? Ta!

[treyhunner]

@carltongibson I haven't worked with the Codecov folks in a while. CC-ing @stevepeak who likely knows where to direct you. Good luck!

[carltongibson]

Hey @treyhunner Sorry for the slow follow-up: Was away for a couple of days, and by then the notification had got totally swamped. 🙂 — Thanks for the response!

[stevepeak]

Hey, sorry for the delay. The missing files would also be missing in the coverage.xml output. I suggest you specify the files directly in the .coveragerc file.

You can debug by running tests locally and calling either coverage report or coverage xml to check to see if the files are in the report.

[carltongibson]

OK. Thanks @stevepeak.

[rpkilby]

Hi @stevepeak - thanks for the response. I ran this locally and took a look at the codecov build, and it appears that the relevant files are included in the report/xml output.

Codecov build

Coverage Report

Name                                                               Stmts   Miss  Cover
--------------------------------------------------------------------------------------
rest_framework/__init__.py                                             9      0   100%
rest_framework/apps.py                                                 6      0   100%
rest_framework/authentication.py                                     103      0   100%
rest_framework/authtoken/__init__.py                                   1      0   100%
rest_framework/authtoken/admin.py                                      7      0   100%
rest_framework/authtoken/apps.py                                       5      0   100%
rest_framework/authtoken/management/__init__.py                        0      0   100%
rest_framework/authtoken/management/commands/__init__.py               0      0   100%
rest_framework/authtoken/management/commands/drf_create_token.py      23      0   100%
rest_framework/authtoken/migrations/0001_initial.py                    6      0   100%
rest_framework/authtoken/migrations/0002_auto_20160226_1747.py         6      0   100%
rest_framework/authtoken/migrations/__init__.py                        0      0   100%
rest_framework/authtoken/models.py                                    23      0   100%
rest_framework/authtoken/serializers.py                               18      0   100%
rest_framework/authtoken/views.py                                     18      0   100%
rest_framework/checks.py                                               7      5    29%
rest_framework/compat.py                                             169     57    66%
rest_framework/decorators.py                                          76      0   100%
rest_framework/documentation.py                                       15      0   100%
rest_framework/exceptions.py                                         125      1    99%
rest_framework/fields.py                                             994     46    95%
rest_framework/filters.py                                            156     12    92%
rest_framework/generics.py                                           102      1    99%
rest_framework/metadata.py                                            59      0   100%
rest_framework/mixins.py                                              54      1    98%
rest_framework/models.py                                               0      0   100%
rest_framework/negotiation.py                                         41      0   100%
rest_framework/pagination.py                                         393     18    95%
rest_framework/parsers.py                                            122     15    88%
rest_framework/permissions.py                                         66      4    94%
rest_framework/relations.py                                          261     11    96%
rest_framework/renderers.py                                          443     47    89%
rest_framework/request.py                                            223     11    95%
rest_framework/response.py                                            50      2    96%
rest_framework/reverse.py                                             34      4    88%
rest_framework/routers.py                                            159      5    97%
rest_framework/schemas/__init__.py                                     7      0   100%
rest_framework/schemas/generators.py                                 235      9    96%
rest_framework/schemas/inspectors.py                                 207     32    85%
rest_framework/schemas/utils.py                                       12      0   100%
rest_framework/schemas/views.py                                       21      2    90%
rest_framework/serializers.py                                        625     27    96%
rest_framework/settings.py                                            59      0   100%
rest_framework/status.py                                              62      0   100%
rest_framework/templatetags/__init__.py                                0      0   100%
rest_framework/templatetags/rest_framework.py                        209     30    86%
rest_framework/test.py                                               210      8    96%
rest_framework/throttling.py                                         105      0   100%
rest_framework/urlpatterns.py                                         31      4    87%
rest_framework/urls.py                                                13      3    77%
rest_framework/utils/__init__.py                                       0      0   100%
rest_framework/utils/breadcrumbs.py                                   30      0   100%
rest_framework/utils/encoders.py                                      48      0   100%
rest_framework/utils/field_mapping.py                                137      9    93%
rest_framework/utils/formatting.py                                    33      2    94%
rest_framework/utils/html.py                                          30      0   100%
rest_framework/utils/humanize_datetime.py                             15      0   100%
rest_framework/utils/json.py                                          17      2    88%
rest_framework/utils/mediatypes.py                                    42      0   100%
rest_framework/utils/model_meta.py                                    54      0   100%
rest_framework/utils/representation.py                                62      5    92%
rest_framework/utils/serializer_helpers.py                            88      9    90%
rest_framework/utils/urls.py                                          14      0   100%
rest_framework/validators.py                                         141      0   100%
rest_framework/versioning.py                                          84      2    98%
rest_framework/views.py                                              225      4    98%
rest_framework/viewsets.py                                            56      3    95%
--------------------------------------------------------------------------------------
TOTAL                                                               6646    391    94%

[stevepeak]

@rpkilby Excellent! Do you see the same results when running this in CI? Can you link me to the Codecov commit report upon your next upload. Thanks!

[rpkilby]

Yep - coverage data in CI seems to include the relevant files (latest codcov build)

Snippet from one of the files:

<class branch-rate="0" complexity="0" filename="serializers.py" line-rate="0.9568" name="serializers.py">
	<methods/>
	<lines>
		<line hits="1" number="13"/>
		<line hits="1" number="15"/>
		<line hits="1" number="16"/>

[carltongibson]

Hi @stevepeak. Is there anything we can do to resolve this?

Here's the latest build on codecov, from just now. https://codecov.io/gh/encode/django-rest-framework/tree/45374449d3915a4c11a28bb52bc32ac64d752c37/rest_framework

Modules are still missing, e.g. at least serializers.py and views.py.

This doesn't look like an issue our end. (Maybe it is? Can you advise?) Do you have a ticket we could track for this?

Thanks!

[stevepeak]

Can you try adding the following your codecov.yml

fixes:
  - "::rest_framework/"

This will move all files into rest_framework/ folder during processing which I think is the issue 😄 Let me know how that goes.

[rpkilby]

Fixed by #5970