Perform pip install as part of bootstrap.py
#25401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
python_bootstrap_deps
branch
2 times, most recently
from
0d220da to
958ae17
Compare
Also, install pip packages in local `out/python_deps` directory instead of installing system wide. This means we can consistently expect dev dependencies to be available in test code without needing to include an opt out mechanism. We were already doing this for `psutil`, but for `websockify` we made it optional. This means that only python scripts that explicitly add `out/python_deps` to their python path will be able use the packages, and in particular it means that the emscripten compiler itself won't end up implicitly/accidentally depending on them.
sbc100
force-pushed
the
python_bootstrap_deps
branch
from
958ae17 to
0bc31ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, install pip packages in local
out/python_depsdirectory insteadof installing system wide.
This means we can consistently expect dev dependencies to be available
in test code without needing to include an opt out mechanism.
We were already doing this for
psutil, but forwebsockifywe madeit optional.
This means that only python scripts that explicitly add
out/python_depsto their python path will be able usethe packages, and in particular it means that the emscripten compiler
itself won't end up implicitly/accidentally depending on them.