[embind] Re-allow references in val code. #25360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandahl
commented
Sep 22, 2025
|
|
||
| template<internal::EM_INVOKER_KIND Kind, typename Policy, typename Ret, typename... Args> | ||
| static Ret internalCall(EM_VAL handle, const char *methodName, Args&&... args) { | ||
| static_assert(!std::is_lvalue_reference<Ret>::value, |
There was a problem hiding this comment.
@RReverser another option is to not allow lvalue references to std::is_arithmetic types.
There was a problem hiding this comment.
In the issue you said we can allow it only with allow_raw_pointers - can we still do that?
There was a problem hiding this comment.
Yeah, I hope to do that in a future PR after #24832 lands.
sbc100
approved these changes
Sep 30, 2025
The static assertion here broke some existing code. In the future, I'd like to change this to support a pointer policy to allow references, but for now I need to get this working again for users.
brendandahl
force-pushed
the
embind-val-allow-rvalue
branch
from
57f8491 to
9f33676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static assertion here broke some existing code. In the future, I'd like to change this to support a pointer policy to allow references, but for now I need to get this working again for users.