Move browser source map test to interactive tests. #25216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbc100 I think this is the test that was clobbering your terminal output. |
sbc100
approved these changes
Sep 8, 2025
sbc100
reviewed
Sep 8, 2025
This test tries to manually launch a browser for verification. This causes issues when trying to launch a browser from headless mode over ssh. The test also doesn't launch the correct file URL in windowed mode, so I'm guessing this hasn't been check for a very long time.
brendandahl
force-pushed
the
remove-manual-test
branch
from
750eef4 to
cbf7a6a
Compare
brendandahl
changed the title
sbc100
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test tries to manually launch a browser for verification. This causes issues when trying to launch a browser from headless mode over ssh. The test also doesn't launch the correct file URL in windowed mode, so I'm guessing this hasn't been checked for a very long time.