Skip to content

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 5, 2025

Since the CI didn't report any OOMs for this suite I assume this should be safe to land.

Test time goes from ~35 or ~21 minutes.

@juj
Copy link
Collaborator

juj commented Sep 5, 2025

Since the CI didn't report any OOMs

I don't think there is an actual >4 GB memory allocation in this suite per VM even with the 4gb bump, but the memory usage stays virtual. I run the wasm64-4gb suite parallel on 256 threads on my linux box, and iirc it consumed only about 30GB of RAM at peak during the suite.

@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 5, 2025

Since the CI didn't report any OOMs

I don't think there is an actual >4 GB memory allocation in this suite per VM even with the 4gb bump, but the memory usage stays virtual. I run the wasm64-4gb suite parallel on 256 threads on my linux box, and iirc it consumed only about 30GB of RAM at peak during the suite.

It certainly used to OOM in the past, which is why this limit was there.. but it seems OK now... at least for this sample size of 1 :-/

@sbc100 sbc100 merged commit 8764744 into emscripten-core:main Sep 5, 2025
30 checks passed
@sbc100 sbc100 deleted the emcc_cores branch September 5, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants