Skip to content

Filter which addon sizes are created #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Filter which addon sizes are created #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3628d68
Replace rake task with what we tend to actually run to generate
lonelyghost Apr 4, 2021
f16a7d8
Skip addon size creation for wip/unreviewed/score < 6
lonelyghost Apr 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/lib/npm_addon_data_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,18 @@ def update_addon_versions
released: @metadata['time'][version],
ember_cli_version: (data['devDependencies'] ? data['devDependencies']['ember-cli'] : nil)
)
if ENV['ADDON_SIZES_ENABLED']
if ENV['ADDON_SIZES_ENABLED'] && should_calculate_size?
PendingSizeCalculation.create!(addon_version: addon_version)
end
@addon.addon_versions << addon_version
update_addon_version_dependencies(addon_version, data)
end
end

def should_calculate_size?
@addon.scorable? && @addon.score >= 6
end

def update_latest_addon_version
latest_version = @metadata['dist-tags']['latest']
@addon.latest_addon_version = @addon.addon_versions.find_by(version: latest_version)
Expand Down
8 changes: 4 additions & 4 deletions lib/tasks/addons.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ namespace :addons do
ReadmeView.refresh
end

desc 'Queue size data calculations for recently updated addons'
desc 'Queue size data calculations for top 1000 addons'
task queue_asset_size_calculations: :environment do
latest_version_ids = Addon.active.where('latest_version_date > ?', 18.months.ago).pluck(:latest_addon_version_id)
latest_version_ids.each do |version_id|
addon_version_ids = Addon.top_n(1000).pluck(:latest_addon_version_id)
addon_version_ids.each do |version_id|
if !AddonSize.exists?(addon_version_id: version_id) && !PendingSizeCalculation.exists?(addon_version_id: version_id)
PendingSizeCalculation.create!(addon_version_id: version_id)
end
end
puts "Created PendingSizeCalculations for #{latest_version_ids.size} addon versions"
puts "Created PendingSizeCalculations for #{addon_version_ids.size} addon versions"
end

desc "Notify Dead Man's Snitch of completion"
Expand Down